linux-kernel - Re: [PATCH] checkpatch: Include GEM_BUG_xxx variant in the excluded check list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b777a049b3817c7eee364310aac89470e9ea882e.camel@perches.com>
Date:   Wed, 14 Jun 2023 18:47:26 -0700
From:   Joe Perches <joe@...ches.com>
To:     "Michael J. Ruhl" <michael.j.ruhl@...el.com>,
        linux-kernel@...r.kernel.org, apw@...onical.com,
        dwaipayanray1@...il.com, lukas.bulwahn@...il.com, corbet@....net,
        david@...hat.com
Subject: Re: [PATCH] checkpatch: Include GEM_BUG_xxx variant in the excluded
 check list

On Wed, 2023-06-14 at 12:49 -0400, Michael J. Ruhl wrote:
> GEM_BUG_ON is usually compiled as WARN.  You have to change to
> debug configuration to get this to be BUG.
> 
> checkpatch flags this a WARN level issue.
> 
> Since this is a i915 local debug macro, allow its use in checkpatch.pl.
> 
> Fixes: 69d517e6e210 ("checkpatch: warn on usage of VM_BUG_ON() and other BUG variants")

Not a "Fixes", just an additional check

> 
> Signed-off-by: Michael J. Ruhl <michael.j.ruhl@...el.com>
> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index b30114d637c4..d3ddde4cd63e 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -4821,7 +4821,7 @@ sub process {
>  		}
>  
>  # do not use BUG() or variants
> -		if ($line =~ /\b(?!AA_|BUILD_|DCCP_|IDA_|KVM_|RWLOCK_|snd_|SPIN_)(?:[a-zA-Z_]*_)?BUG(?:_ON)?(?:_[A-Z_]+)?\s*\(/) {
> +		if ($line =~ /\b(?!AA_|BUILD_|DCCP_|GEM_|IDA_|KVM_|RWLOCK_|snd_|SPIN_)(?:[a-zA-Z_]*_)?BUG(?:_ON)?(?:_[A-Z_]+)?\s*\(/) {
>  			my $msg_level = \&WARN;
>  			$msg_level = \&CHK if ($file);
>  			&{$msg_level}("AVOID_BUG",