[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2023061555-spyglass-most-fccf@gregkh>
Date: Thu, 15 Jun 2023 12:46:05 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Philipp Hortmann <philipp.g.hortmann@...il.com>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] staging: rtl8192e: Use standard api to calculate
frequency to channel
On Thu, Jun 08, 2023 at 08:52:18AM +0200, Philipp Hortmann wrote:
> Use ieee80211_freq_khz_to_channel() to calculate frequency to channel to
> omit proprietary code.
>
> Signed-off-by: Philipp Hortmann <philipp.g.hortmann@...il.com>
> ---
> Tested this code with separate debug code as this part is usually unused.
> ---
> drivers/staging/rtl8192e/rtllib_softmac_wx.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib_softmac_wx.c b/drivers/staging/rtl8192e/rtllib_softmac_wx.c
> index 78a70e5f1974..6fd2e94d5f8a 100644
> --- a/drivers/staging/rtl8192e/rtllib_softmac_wx.c
> +++ b/drivers/staging/rtl8192e/rtllib_softmac_wx.c
> @@ -42,15 +42,8 @@ int rtllib_wx_set_freq(struct rtllib_device *ieee, struct iw_request_info *a,
> if (fwrq->e == 1) {
> if ((fwrq->m >= (int)2.412e8 &&
> fwrq->m <= (int)2.487e8)) {
> - int f = fwrq->m / 100000;
> - int c = 0;
> -
> - while ((c < 14) && (f != rtllib_wlan_frequencies[c]))
> - c++;
> -
> - /* hack to fall through */
> + fwrq->m = ieee80211_freq_khz_to_channel(fwrq->m / 100);
> fwrq->e = 0;
> - fwrq->m = c + 1;
> }
> }
>
> --
> 2.40.1
>
>
Does not apply to my tree for some reason, can you rebase and resubmit?
thanks,
greg k-h
Powered by blists - more mailing lists