linux-kernel - RE: [PATCH] crypto: caam - adjust RNG timing to support more devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM0PR04MB60047C920624933DF21C186DE75BA@AM0PR04MB6004.eurprd04.prod.outlook.com>
Date:   Thu, 15 Jun 2023 11:45:07 +0000
From:   Gaurav Jain <gaurav.jain@....com>
To:     Meenakshi Aggarwal <meenakshi.aggarwal@....com>,
        Horia Geanta <horia.geanta@....com>,
        Varun Sethi <V.Sethi@....com>,
        Pankaj Gupta <pankaj.gupta@....com>,
        "herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Victoria Milhoan <vicki.milhoan@...escale.com>,
        Dan Douglass <dan.douglass@....com>,
        Vipul Kumar <vipul_kumar@...tor.com>
Subject: RE: [PATCH] crypto: caam - adjust RNG timing to support more devices

Reviewed-by: Gaurav Jain <gaurav.jain@....com>

> -----Original Message-----
> From: Meenakshi Aggarwal <meenakshi.aggarwal@....com>
> Sent: Monday, June 12, 2023 1:56 PM
> To: Horia Geanta <horia.geanta@....com>; Varun Sethi <V.Sethi@....com>;
> Pankaj Gupta <pankaj.gupta@....com>; Gaurav Jain <gaurav.jain@....com>;
> herbert@...dor.apana.org.au; davem@...emloft.net; linux-
> crypto@...r.kernel.org; linux-kernel@...r.kernel.org
> Cc: Victoria Milhoan <vicki.milhoan@...escale.com>; Dan Douglass
> <dan.douglass@....com>; Vipul Kumar <vipul_kumar@...tor.com>
> Subject: [PATCH] crypto: caam - adjust RNG timing to support more devices
> 
> From: Victoria Milhoan <vicki.milhoan@...escale.com>
> 
> Adjust RNG timing parameters to support more i.MX6 devices.
> 
> Signed-off-by: Victoria Milhoan <vicki.milhoan@...escale.com>
> Signed-off-by: Dan Douglass <dan.douglass@....com>
> Signed-off-by: Vipul Kumar <vipul_kumar@...tor.com>
> Signed-off-by: Horia Geantă <horia.geanta@....com>
> ---
>  drivers/crypto/caam/ctrl.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.c index
> 5fed3cf354c0..62dd069942e4 100644
> --- a/drivers/crypto/caam/ctrl.c
> +++ b/drivers/crypto/caam/ctrl.c
> @@ -383,8 +383,8 @@ static void kick_trng(struct device *dev, int ent_delay)
>  	wr_reg32(&r4tst->rtsdctl, val);
>  	/* min. freq. count, equal to 1/4 of the entropy sample length */
>  	wr_reg32(&r4tst->rtfrqmin, ent_delay >> 2);
> -	/* disable maximum frequency count */
> -	wr_reg32(&r4tst->rtfrqmax, RTFRQMAX_DISABLE);
> +	/* max. freq. count, equal to 16 times the entropy sample length */
> +	wr_reg32(&r4tst->rtfrqmax, ent_delay << 4);
>  	/* read the control register */
>  	val = rd_reg32(&r4tst->rtmctl);
>  start_rng:
> --
> 2.25.1