linux-kernel - Re: [PATCH v1] drivers:net:dsa:Fix resource leaks in fwnode_for_each_child

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZIsME1gwEWEyyN1o@corigine.com>
Date:   Thu, 15 Jun 2023 15:03:15 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Wang Ming <machel@...o.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        opensource.kernel@...o.com
Subject: Re: [PATCH v1] drivers:net:dsa:Fix resource leaks in
 fwnode_for_each_child_node() loops

On Thu, Jun 15, 2023 at 03:04:58PM +0800, Wang Ming wrote:
>  The fwnode_for_each_child_node loop in qca8k_setup_led_ctrl should
>  have fwnode_handle_put() before return which could avoid resource leaks.
>  This patch could fix this bug.
> 
> Signed-off-by: Wang Ming <machel@...o.com>

Hi Wang Ming,

unfortunately your patch has been whitespace mangled - tabs have been
converted into 8 spaces. Possibly this was done by your mail client
or mail server. In any case the result is that the patch doesn't apply.
And unfortunately that breaks our processes.

Also, I'm assuming that as this patch is a fix, it is targeted at the
"net", as opposed to "net-next", tree. This should be noted in the subject.

	Subject: [PATCH net v2] ...

Lastly, looking at the git history of qca8k-leds.c, I think that
a better prefix for the patch is "net: dsa: qca8k: ".

	Subject: [PATCH net v2] net: dsa: qca8k: ...

Please consider addressing the problems and reposting your patch.

-- 
pw-bot: changes-requested