linux-kernel - Re: [PATCH] wifi: mt76: mt7921e: Perform FLR to recovery the device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <10d7045eca2bdf40d7a69df7c2d7eafad2584d05.camel@mediatek.com>
Date:   Fri, 16 Jun 2023 14:17:41 +0000
From:   Deren Wu (武德仁) <Deren.Wu@...iatek.com>
To:     "kai.heng.feng@...onical.com" <kai.heng.feng@...onical.com>,
        "nbd@....name" <nbd@....name>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>,
        "lorenzo@...nel.org" <lorenzo@...nel.org>,
        Ryder Lee <Ryder.Lee@...iatek.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        Leon Yen (顏良儒) <Leon.Yen@...iatek.com>,
        Shayne Chen (陳軒丞) 
        <Shayne.Chen@...iatek.com>, "Sean Wang" <Sean.Wang@...iatek.com>,
        "kvalo@...nel.org" <kvalo@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>
Subject: Re: [PATCH] wifi: mt76: mt7921e: Perform FLR to recovery the device

On Wed, 2023-06-14 at 13:18 +0200, AngeloGioacchino Del Regno wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  Il 14/06/23 08:32, Kai-Heng Feng ha scritto:
> > When "Pre-boot WiFi" is enabled in BIOS, the mt7921e device may not
> > work:
> > mt7921e 0000:02:00.0: ASIC revision: 79220010
> > mt7921e 0000:02:00.0: Message 00000010 (seq 1) timeout
> > mt7921e 0000:02:00.0: Failed to get patch semaphore
> > mt7921e 0000:02:00.0: Message 00000010 (seq 2) timeout
> > mt7921e 0000:02:00.0: Failed to get patch semaphore
> > mt7921e 0000:02:00.0: Message 00000010 (seq 3) timeout
> > mt7921e 0000:02:00.0: Failed to get patch semaphore
> > mt7921e 0000:02:00.0: Message 00000010 (seq 4) timeout
> > mt7921e 0000:02:00.0: Failed to get patch semaphore
> > mt7921e 0000:02:00.0: Message 00000010 (seq 5) timeout
> > mt7921e 0000:02:00.0: Failed to get patch semaphore
> > mt7921e 0000:02:00.0: Message 00000010 (seq 6) timeout
> > mt7921e 0000:02:00.0: Failed to get patch semaphore
> > mt7921e 0000:02:00.0: Message 00000010 (seq 7) timeout
> > mt7921e 0000:02:00.0: Failed to get patch semaphore
> > mt7921e 0000:02:00.0: Message 00000010 (seq 8) timeout
> > mt7921e 0000:02:00.0: Failed to get patch semaphore
> > mt7921e 0000:02:00.0: Message 00000010 (seq 9) timeout
> > mt7921e 0000:02:00.0: Failed to get patch semaphore
> > mt7921e 0000:02:00.0: Message 00000010 (seq 10) timeout
> > mt7921e 0000:02:00.0: Failed to get patch semaphore
> > mt7921e 0000:02:00.0: hardware init failed
> > 
> > After some trials and errors, it shows that PCI function level
> reset can
> > recover the device back to a functional state.
> > 
> > So perform FLR at probe routine to workaround the issue.
> 
> Is there any way to check if the device was enabled before booting
> Linux?
> 
> I'm thinking of something like
> 
> if (device_is_already_enabled)
> ret = pci_reset_function_locked(....)
> 
> Regards,
> Angelo

Hi Kai-Heng,

Thanks for the patch. But we found there are some problems on different
platform. We will provide another solution for this case.


Hi Angelo,

Because the problem is caused by mt7912e enabled and some status was
changed to an unpreditable value durgin boot process, we may have to
force reset devices in probe(). We still try to find out a good way to
do it and will post the patch once the verification is done.


Regards,
Deren

> 
> > 
> > Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>
> > ---
> >   drivers/net/wireless/mediatek/mt76/mt7921/pci.c | 4 ++++
> >   1 file changed, 4 insertions(+)
> > 
> > diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
> b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
> > index ddb1fa4ee01d..9671fbe35a8e 100644
> > --- a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
> > +++ b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
> > @@ -262,6 +262,10 @@ static int mt7921_pci_probe(struct pci_dev
> *pdev,
> >   int ret;
> >   u16 cmd;
> >   
> > +ret = pci_reset_function_locked(pdev);
> > +if (ret)
> > +pci_info(pdev, "Unable to perform FLR\n");
> > +
> >   ret = pcim_enable_device(pdev);
> >   if (ret)
> >   return ret;
> 
>