linux-kernel - Re: [PATCH v3 1/4] ARM: tegra: transformer: use labels for mmc in aliases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 16 Jun 2023 18:24:10 +0300
From:   Svyatoslav Ryhel <clamor95@...il.com>
To:     Thierry Reding <thierry.reding@...il.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Dmitry Osipenko <digetx@...il.com>,
        Svyatoslav Ryhel <clamor95@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Maxim Schwalm <maxim.schwalm@...il.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        devicetree@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/4] ARM: tegra: transformer: use labels for mmc in aliases

ср, 29 бер. 2023 р. о 12:04 Svyatoslav Ryhel <clamor95@...il.com> пише:
>
> Use phandle references for mmc instead of path in aliases.
>
> Signed-off-by: Svyatoslav Ryhel <clamor95@...il.com>
> ---
>  arch/arm/boot/dts/tegra114-asus-tf701t.dts           | 12 ++++++------
>  .../boot/dts/tegra30-asus-transformer-common.dtsi    | 12 ++++++------
>  2 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm/boot/dts/tegra114-asus-tf701t.dts b/arch/arm/boot/dts/tegra114-asus-tf701t.dts
> index 84a3eb38e71d..3a420ac969ff 100644
> --- a/arch/arm/boot/dts/tegra114-asus-tf701t.dts
> +++ b/arch/arm/boot/dts/tegra114-asus-tf701t.dts
> @@ -13,9 +13,9 @@ / {
>         chassis-type = "convertible";
>
>         aliases {
> -               mmc0 = "/mmc@...00600"; /* eMMC */
> -               mmc1 = "/mmc@...00400"; /* uSD slot */
> -               mmc2 = "/mmc@...00000"; /* WiFi */
> +               mmc0 = &sdmmc4; /* eMMC */
> +               mmc1 = &sdmmc3; /* uSD slot */
> +               mmc2 = &sdmmc1; /* WiFi */
>
>                 rtc0 = &palmas;
>                 rtc1 = "/rtc@...0e000";
> @@ -605,12 +605,12 @@ i2s@...80300 {
>                 };
>         };
>
> -       mmc@...00000 {
> +       sdmmc1: mmc@...00000 {
>                 /* WiFi */
>         };
>
>         /* MicroSD card */
> -       mmc@...00400 {
> +       sdmmc3: mmc@...00400 {
>                 status = "okay";
>
>                 bus-width = <4>;
> @@ -626,7 +626,7 @@ mmc@...00400 {
>                 pinctrl-0 = <&sdmmc3_default>;
>         };
>
> -       mmc@...00600 {
> +       sdmmc4: mmc@...00600 {
>                 /* eMMC */
>         };
>
> diff --git a/arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi b/arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi
> index 1861b2de2dc3..f32806f07989 100644
> --- a/arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi
> +++ b/arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi
> @@ -12,9 +12,9 @@ / {
>         chassis-type = "convertible";
>
>         aliases {
> -               mmc0 = "/mmc@...00600"; /* eMMC */
> -               mmc1 = "/mmc@...00000"; /* uSD slot */
> -               mmc2 = "/mmc@...00400"; /* WiFi */
> +               mmc0 = &sdmmc4; /* eMMC */
> +               mmc1 = &sdmmc1; /* uSD slot */
> +               mmc2 = &sdmmc3; /* WiFi */
>
>                 rtc0 = &pmic;
>                 rtc1 = "/rtc@...0e000";
> @@ -1388,7 +1388,7 @@ i2s@...80600 {            /* i2s3 */
>                 };
>         };
>
> -       mmc@...00000 {
> +       sdmmc1: mmc@...00000 {
>                 status = "okay";
>
>                 /* FIXME: Full 208Mhz clock rate doesn't work reliably */
> @@ -1401,7 +1401,7 @@ mmc@...00000 {
>                 vqmmc-supply = <&vddio_usd>;    /* ldo3 */
>         };
>
> -       mmc@...00400 {
> +       sdmmc3: mmc@...00400 {
>                 status = "okay";
>
>                 #address-cells = <1>;
> @@ -1431,7 +1431,7 @@ wifi@1 {
>                 };
>         };
>
> -       mmc@...00600 {
> +       sdmmc4: mmc@...00600 {
>                 status = "okay";
>                 bus-width = <8>;
>                 vmmc-supply = <&vcore_emmc>;
> --
> 2.37.2
>

Hello Thierry!
For some reason this commit was not picked while all others in
the patchset were. May I know why and how to fix this?

Best regards,
Svyatoslav R.