linux-kernel - Re: [PATCH v3 1/6] soundwire: bus: Allow SoundWire peripherals to register IRQ handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230616160156.GT68926@ediswmail.ad.cirrus.com>
Date:   Fri, 16 Jun 2023 16:01:56 +0000
From:   Charles Keepax <ckeepax@...nsource.cirrus.com>
To:     <andy.shevchenko@...il.com>
CC:     <broonie@...nel.org>, <lee@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <linus.walleij@...aro.org>,
        <vkoul@...nel.org>, <robh+dt@...nel.org>, <conor+dt@...nel.org>,
        <lgirdwood@...il.com>, <yung-chuan.liao@...ux.intel.com>,
        <sanyog.r.kale@...el.com>, <pierre-louis.bossart@...ux.intel.com>,
        <alsa-devel@...a-project.org>, <patches@...nsource.cirrus.com>,
        <devicetree@...r.kernel.org>, <linux-gpio@...r.kernel.org>,
        <linux-spi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/6] soundwire: bus: Allow SoundWire peripherals to
 register IRQ handlers

On Fri, Jun 16, 2023 at 01:14:53AM +0300, andy.shevchenko@...il.com wrote:
> Mon, Jun 05, 2023 at 01:54:59PM +0100, Charles Keepax kirjoitti:
> > From: Lucas Tanure <tanureal@...nsource.cirrus.com>
> > +	bus->irq_chip.name = dev_name(bus->dev);
> > +	bus->domain = irq_domain_add_linear(NULL, SDW_MAX_DEVICES, &sdw_domain_ops, bus);
> 
> I'm wondering why you are not using existing fwnode, if any
> (e.g. from parent device).

I think that is just an oversight, I will fixup for the next
version.

Thanks,
Charles