linux-kernel - Re: [PATCH] nvdimm: make security

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6d81a3a7-9b00-d00c-1786-0238d35310e1@intel.com>
Date:   Fri, 16 Jun 2023 09:14:42 -0700
From:   Dave Jiang <dave.jiang@...el.com>
To:     Ben Dooks <ben.dooks@...ethink.co.uk>, <nvdimm@...ts.linux.dev>
CC:     <linux-kernel@...r.kernel.org>, <dan.j.williams@...el.com>,
        <vishal.l.verma@...el.com>, <ira.weiny@...el.com>
Subject: Re: [PATCH] nvdimm: make security_show static



On 6/16/23 09:09, Ben Dooks wrote:
> The security_show function is not used outsid of drivers/nvdimm/dimm_devs.c

s/outsid/outside/

> and the attribute it is for is also already static. Silence the sparse
> warning for this not being declared by making it static. Fixes:
> 
> drivers/nvdimm/dimm_devs.c:352:9: warning: symbol 'security_show' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>

Reviewed-by: Dave Jiang <dave.jiang@...el.com>

> ---
>   drivers/nvdimm/dimm_devs.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/nvdimm/dimm_devs.c b/drivers/nvdimm/dimm_devs.c
> index 957f7c3d17ba..1273873582be 100644
> --- a/drivers/nvdimm/dimm_devs.c
> +++ b/drivers/nvdimm/dimm_devs.c
> @@ -349,8 +349,8 @@ static ssize_t available_slots_show(struct device *dev,
>   }
>   static DEVICE_ATTR_RO(available_slots);
>   
> -ssize_t security_show(struct device *dev,
> -		struct device_attribute *attr, char *buf)
> +static ssize_t security_show(struct device *dev,
> +			     struct device_attribute *attr, char *buf)
>   {
>   	struct nvdimm *nvdimm = to_nvdimm(dev);
>