lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <SJ1PR11MB6180B8CEF4F0F86E405908CBB858A@SJ1PR11MB6180.namprd11.prod.outlook.com>
Date:   Fri, 16 Jun 2023 16:39:35 +0000
From:   "Zulkifli, Muhammad Husaini" <muhammad.husaini.zulkifli@...el.com>
To:     Florian Kauer <florian.kauer@...utronix.de>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        "Gomes, Vinicius" <vinicius.gomes@...el.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "Tan Tee Min" <tee.min.tan@...ux.intel.com>,
        "Gunasekaran, Aravindhan" <aravindhan.gunasekaran@...el.com>,
        "Chilakala, Mallikarjuna" <mallikarjuna.chilakala@...el.com>
CC:     "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kurt@...utronix.de" <kurt@...utronix.de>
Subject: RE: [PATCH net-next 0/6] igc: Fix corner cases for TSN offload



> -----Original Message-----
> From: Florian Kauer <florian.kauer@...utronix.de>
> Sent: Saturday, 17 June, 2023 12:11 AM
> To: Zulkifli, Muhammad Husaini <muhammad.husaini.zulkifli@...el.com>;
> Brandeburg, Jesse <jesse.brandeburg@...el.com>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; Gomes, Vinicius <vinicius.gomes@...el.com>;
> David S . Miller <davem@...emloft.net>; Eric Dumazet
> <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni
> <pabeni@...hat.com>; Tan Tee Min <tee.min.tan@...ux.intel.com>;
> Gunasekaran, Aravindhan <aravindhan.gunasekaran@...el.com>; Chilakala,
> Mallikarjuna <mallikarjuna.chilakala@...el.com>
> Cc: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; kurt@...utronix.de
> Subject: Re: [PATCH net-next 0/6] igc: Fix corner cases for TSN offload
> 
> On 16.06.23 17:53, Zulkifli, Muhammad Husaini wrote:
> >> Florian Kauer (6):
> >>   igc: Rename qbv_enable to taprio_offload_enable
> >>   igc: Do not enable taprio offload for invalid arguments
> >>   igc: Handle already enabled taprio offload for basetime 0
> >>   igc: No strict mode in pure launchtime/CBS offload
> >>   igc: Fix launchtime before start of cycle
> >>   igc: Fix inserting of empty frame for launchtime
> >
> > All six patches, as far as I can see here, have the Fixes tag. Should they go to
> Net instead of Net-Next?
> 
> You are correct, these are all fixes and could go to net.
> However, in its current form they will not fully apply to net (e.g. due to the
> commit 2d800bc500fb ("net/sched: taprio: replace tc_taprio_qopt_offload ::
> enable with a "cmd" enum") that has overlapping code changes) and are also
> not tested with net.
> If you prefer to have them in net already I could send a second series.
> For me personally all options (net, net-next or iwl-next) would be fine.

Yeah I would prefer "net" so that it can be available in current development kernel.
"Net-next" will take sometimes to go in....
Looks like only patch no 2 "igc: Do not enable taprio offload for invalid arguments"
will have conflict due to the new "cmd" command introduced by vlamidir. 
But I think should be minor changes.

Thanks

> 
> Thanks,
> Florian

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ