linux-kernel - Re: [PATCH v3 3/3] soc: loongson2_pm: add power management support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15c4c3cf-819b-c298-c212-d58b1e28ccd8@loongson.cn>
Date:   Fri, 16 Jun 2023 12:01:56 +0800
From:   zhuyinbo <zhuyinbo@...ngson.cn>
To:     Huacai Chen <chenhuacai@...nel.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        zhuyinbo@...ngson.cn, Conor Dooley <conor+dt@...nel.org>,
        WANG Xuerui <kernel@...0n.name>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Pavel Machek <pavel@....cz>, Marc Zyngier <maz@...nel.org>,
        Arnd Bergmann <arnd@...db.de>, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        loongarch@...ts.linux.dev, Jianmin Lv <lvjianmin@...ngson.cn>,
        wanghongliang@...ngson.cn, Liu Peibao <liupeibao@...ngson.cn>,
        loongson-kernel@...ts.loongnix.cn
Subject: Re: [PATCH v3 3/3] soc: loongson2_pm: add power management support



在 2023/6/16 上午9:54, Huacai Chen 写道:
> Hi, Yinbo,
> 
> On Fri, Jun 16, 2023 at 9:45 AM zhuyinbo <zhuyinbo@...ngson.cn> wrote:

...

>>>
>>>
>>> okay, I got it.
>>>
>>>>
>>>>> +}
>>>>> +
>>>>> +static void loongson2_power_button_irq_enable(void)
>>>>
>>>> Using loongson2_pm_irq_enable is a little better.
>>>
>>>
>>
>> Previously, you suggested that I combine loongson2_pm_irq_enable() and
>> power button irq enable code as loongson2_power_button_irq_enable, then
>> I remove the function loongson2_pm_irq_enable, in this case that I won't
>> be able to call loongson2_pm_irq_enable, so have I misunderstood your
>> meaning ? or only rename loongson2_power_button_irq_enable as
>> loongson2_pm_irq_enable ?
> I'm very sorry for that. At first I only wanted to combine two
> functions, but then I found the name  loongson2_pm_irq_enable is
> better. So just rename is OK. Thanks.
> 


okay, I got it.

Thanks,
Yinbo