linux-kernel - Re: [PATCH AUTOSEL 6.1 20/33] ASoC: Intel: avs: Account for UID of ACPI device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZIy4xhk+kbe01gio@duo.ucw.cz>
Date:   Fri, 16 Jun 2023 21:32:22 +0200
From:   Pavel Machek <pavel@...x.de>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Cezary Rojewski <cezary.rojewski@...el.com>,
        Amadeusz Sławiński 
        <amadeuszx.slawinski@...ux.intel.com>,
        Mark Brown <broonie@...nel.org>, lgirdwood@...il.com,
        perex@...ex.cz, tiwai@...e.com,
        pierre-louis.bossart@...ux.intel.com,
        peter.ujfalusi@...ux.intel.com, yung-chuan.liao@...ux.intel.com,
        ranjani.sridharan@...ux.intel.com, kai.vehmanen@...ux.intel.com,
        ahplka19@...il.com, alsa-devel@...a-project.org
Subject: Re: [PATCH AUTOSEL 6.1 20/33] ASoC: Intel: avs: Account for UID of
 ACPI device

Hi!

> Configurations with multiple codecs attached to the platform are
> supported but only if each from the set is different. Add new field
> representing the 'Unique ID' so that codecs that share Vendor and Part
> IDs can be differentiated and thus enabling support for such
> configurations.

Apparently this is preparation for something, but we should not need
it in AUTOSEL as noone will write the uid here.

Best regards,
								Pavel

> +++ b/include/sound/soc-acpi.h
> @@ -170,6 +170,7 @@ struct snd_soc_acpi_link_adr {
>  /* Descriptor for SST ASoC machine driver */
>  struct snd_soc_acpi_mach {
>  	u8 id[ACPI_ID_LEN];
> +	const char *uid;
>  	const struct snd_soc_acpi_codecs *comp_ids;
>  	const u32 link_mask;
>  	const struct snd_soc_acpi_link_adr *links;
> diff --git a/sound/soc/intel/avs/board_selection.c b/sound/soc/intel/avs/board_selection.c
> index 87f9c18be238d..87353b4b0cd73 100644
> --- a/sound/soc/intel/avs/board_selection.c
> +++ b/sound/soc/intel/avs/board_selection.c
> @@ -394,7 +394,7 @@ static int avs_register_i2s_boards(struct avs_dev *adev)
>  	}
>  
>  	for (mach = boards->machs; mach->id[0]; mach++) {
> -		if (!acpi_dev_present(mach->id, NULL, -1))
> +		if (!acpi_dev_present(mach->id, mach->uid, -1))
>  			continue;
>  
>  		if (mach->machine_quirk)

-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)