linux-kernel - Re: [PATCH] syscalls: Fix file path names in the header comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <c2f3656f-b831-4009-8ee6-a2430c4ac8c7@app.fastmail.com>
Date:   Fri, 16 Jun 2023 22:11:49 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Sohil Mehta" <sohil.mehta@...el.com>
Cc:     linux-kernel@...r.kernel.org, linux-api@...r.kernel.org,
        Linux-Arch <linux-arch@...r.kernel.org>
Subject: Re: [PATCH] syscalls: Fix file path names in the header comments

On Fri, Jun 16, 2023, at 20:31, Sohil Mehta wrote:
> Some of the syscall definitions have moved due to the original source
> file being moved into a sub-directory. Update the file path names to
> reflect that.
>
> A couple of syscalls such as lookup_dcookie() and nfsservctl() don't
> have a syscall definition anymore. Clear the filename and leave the
> original subsystem name intact for reference.
>
> Signed-off-by: Sohil Mehta <sohil.mehta@...el.com>

Thanks for going through these!

> Arguably, having filenames in comments might not be the best idea.  If the
> intention is to make it easier to find a syscall definition, it is probably
> faster to just use 'git grep SYSCALL_DEFINE | grep <syscall_name>'.  Please let
> me know if it would be preferable to just get rid of these comments all
> together.

It's probably not worth trying to keep the comments in sync, I'd be in
favor of just removing them all.

     Arnd