linux-kernel - Re: [PATCH v6 18/22] clk: qcom: smd-rpm: Separate out interconnect bus clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <70c39db97475939719720ab1902aa1c1.sboyd@kernel.org>
Date:   Fri, 16 Jun 2023 13:27:42 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Evan Green <evgreen@...omium.org>,
        Georgi Djakov <djakov@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Leo Yan <leo.yan@...aro.org>,
        Michael Turquette <mturquette@...libre.com>,
        Rob Herring <robh+dt@...nel.org>
Cc:     Marijn Suijten <marijn.suijten@...ainline.org>,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v6 18/22] clk: qcom: smd-rpm: Separate out interconnect bus clocks

Quoting Konrad Dybcio (2023-06-15 00:49:59)
> On 15.06.2023 02:48, Stephen Boyd wrote:
> > Quoting Konrad Dybcio (2023-06-14 11:04:37)
> >> @@ -1332,6 +1275,15 @@ static int rpm_smd_clk_probe(struct platform_device *pdev)
> >>                         goto err;
> >>         }
> >>  
> >> +       for (i = 0; i < desc->num_icc_clks; i++) {
> >> +               if (!desc->icc_clks[i])
> >> +                       continue;
> >> +
> >> +               ret = clk_smd_rpm_handoff(desc->icc_clks[i]);
> > 
> > This API can probably take a const struct clk_smd_rpm pointer as well.
> It would be great, but ideally we want to set r->enabled in that func
> for !bus clocks (for unused clk cleanup). I could probably introduce a
> separate function for the icc clocks that takes const.
> 

Sure. Or have this take const and in the clk driver set r->enabled after
calling it. That's future code though, so just make it take const?