linux-kernel - RE: [PATCH 1/2] platform/chrome: cros_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 16 Jun 2023 21:57:01 +0000
From:   "Patel, Utkarsh H" <utkarsh.h.patel@...el.com>
To:     Prashant Malani <pmalani@...omium.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "heikki.krogerus@...ux.intel.com" <heikki.krogerus@...ux.intel.com>,
        "bleung@...omium.org" <bleung@...omium.org>
Subject: RE: [PATCH 1/2] platform/chrome: cros_ec_typec: Configure Retimer
 cable type

Hi Prashant,

Thank you for the review and feedback.

> > Connector class driver only configure cable type active or passive.
> > With this change it will also configure if the cable type is retimer
> > or redriver if required by AP. This details will be provided by Chrome
> > EC as a part of cable discover mode VDO.
> >
> > This change also brings in corresponding EC header updates from the EC
> > code base [1].
> 
> Please separate this into another patch.

I can do that but since it's just one line change and related, kept it together. 

> > a/include/linux/platform_data/cros_ec_commands.h
> > b/include/linux/platform_data/cros_ec_commands.h
> > index ab721cf13a98..c9aa5495c666 100644
> > --- a/include/linux/platform_data/cros_ec_commands.h
> > +++ b/include/linux/platform_data/cros_ec_commands.h
> > @@ -4963,6 +4963,8 @@ struct ec_response_usb_pd_control_v1 {  #define
> > USB_PD_CTRL_TBT_LEGACY_ADAPTER  BIT(2)
> >  /* Active Link Uni-Direction */
> >  #define USB_PD_CTRL_ACTIVE_LINK_UNIDIR  BIT(3)
> > +/* Retimer/Redriver cable */
> > +#define USB_PD_CTRL_RETIMER_CABLE BIT(4)
> 
> Why are we adding this to this host commands interface? Is this information
> not available from the Cable (plug)'s Identity information? We register all of
> that in the port driver already [1], so we should just use that, instead of
> changing the host command interface.

All the cable details used to configure Alternate mode and USB4 mode in this driver are provided from EC host command. 
To stay consistent with the existing implementation, it was added to the existing host command. 

Sincerely,
Utkarsh Patel.