linux-kernel - Re: [BUG] _regmap_raw_write()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEP57O9c2Ano4qU5V4EK3ePoBHz+N1xFDo8ULEvidPFnBX+0cw@mail.gmail.com>
Date:   Fri, 16 Jun 2023 17:39:05 -0500
From:   Jim Wylder <jwylder@...gle.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     Russ Weight <russell.h.weight@...el.com>,
        "Gerlach, Matthew" <matthew.gerlach@...ux.intel.com>,
        linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>
Subject: Re: [BUG] _regmap_raw_write() - divide-by-zero

Sorry for causing the grief.

For the description would it be something like "Max transfer size
supported on a write"?
Or does that still not describe it correctly?

Jim

On Fri, Jun 16, 2023 at 5:14 PM Mark Brown <broonie@...nel.org> wrote:
>
> On Fri, Jun 16, 2023 at 02:58:24PM -0700, Russ Weight wrote:
>
> > The origination of the regmap->max_raw_write value is here:
> > https://github.com/torvalds/linux/blob/4973ca29552864a7a047ab8a15611a585827412f/drivers/base/regmap/regmap-spi-avmm.c#L663
> > > .max_raw_write = SPI_AVMM_VAL_SIZE * MAX_WRITE_CNT,
>
> > SPI_AVMM_VAL_SIZE is defined as 4, and MAX_WRITE_CNT is defined as 1
>
> This should add in some headroom for the value too.
>
> We should also fix the max_raw_write comments since it's a bit confusing
> between users and buses, though AFAICT nothing outside the core ever
> checks.