linux-kernel - Re: [PATCH v3 1/3] Docs/RCU/rculist_nulls: Specify type of the object in examples

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e55f9cd3-d0a3-40f0-9c5f-a0a4229a87b0@paulmck-laptop>
Date:   Fri, 16 Jun 2023 16:18:27 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     SeongJae Park <sj@...nel.org>
Cc:     Alan Huang <mmpgouride@...il.com>,
        Joel Fernandes <joel@...lfernandes.org>, corbet@....net,
        rcu@...r.kernel.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/3] Docs/RCU/rculist_nulls: Specify type of the
 object in examples

On Fri, Jun 16, 2023 at 06:54:11PM +0000, SeongJae Park wrote:
> On Sat, 17 Jun 2023 01:46:16 +0800 Alan Huang <mmpgouride@...il.com> wrote:
> 
> > 
> > > 2023年6月16日 02:10，SeongJae Park <sj@...nel.org> 写道：
> > > 
> > > The type of 'obj' in example code of rculist_nulls.rst is implicit.
> > > Provide the specific type of it before the example code.
> > > 
> > > Suggested-by: aul E. McKenney <paulmck@...nel.org>
> > 
> > Paul E. McKenney
> 
> Oops, thank you for finding, and sorry, Paul :)

Not a problem, just send new patches and I will replace those currently
in -rcu with those new patches.

							Thanx, Paul

> > > Link: https://lore.kernel.org/rcu/43943609-f80c-4b6a-9844-994eef800757@paulmck-laptop/
> > > Signed-off-by: SeongJae Park <sj@...nel.org>
> > > ---
> > > Documentation/RCU/rculist_nulls.rst | 14 +++++++++++++-
> > > 1 file changed, 13 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/Documentation/RCU/rculist_nulls.rst b/Documentation/RCU/rculist_nulls.rst
> > > index 94a8bfe9f560..4b66e2fd2fb5 100644
> > > --- a/Documentation/RCU/rculist_nulls.rst
> > > +++ b/Documentation/RCU/rculist_nulls.rst
> > > @@ -18,7 +18,16 @@ to solve following problem.
> > > 
> > > Without 'nulls', a typical RCU linked list managing objects which are
> > > allocated with SLAB_TYPESAFE_BY_RCU kmem_cache can use the following
> > > -algorithms:
> > > +algorithms.  Following examples assume 'obj' is a pointer to such
> > > +objects, which is having below type.
> > > +
> > > +::
> > > +
> > > +  struct object {
> > > +    struct hlist_node obj_node;
> > > +    refcount_t refcnt;
> > 
> > atomic_t
> 
> I just recalled the example code uses atomic_set_release() for this field.
> 
> Thank you, Alan!
> 
> I will fix these in the next spin.
> 
> 
> Thanks,
> SJ
> 
> > 
> > > +    unsigned int key;
> > > +  };
> > > 
> > > 1) Lookup algorithm
> > > -------------------
> > > @@ -142,6 +151,9 @@ the beginning. If the object was moved to the same chain,
> > > then the reader doesn't care: It might occasionally
> > > scan the list again without harm.
> > > 
> > > +Note that using hlist_nulls means the type of 'obj_node' field of
> > > +'struct object' becomes 'struct hlist_nulls_node'.
> > > +
> > > 
> > > 1) lookup algorithm
> > > -------------------
> > > -- 
> > > 2.25.1
> > > 
> > 
> >