linux-kernel - Re: [RESEND PATCH v4 -next] tty: serial: add panic serial helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <32e022c7-f041-3bf2-2f68-3ed2119c951d@kylinos.cn>
Date:   Fri, 16 Jun 2023 14:19:50 +0800
From:   Hongyu Xie <xiehongyu1@...inos.cn>
To:     linux@...linux.org.uk, gregkh@...uxfoundation.org,
        jirislaby@...nel.org, corbet@....net
Cc:     rdunlap@...radead.org, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org, xy521521@...il.com,
        oe-kbuild-all@...ts.linux.dev, lkp@...el.com, bagasdotme@...il.com,
        Hongyu Xie <xiehongyu1@...inos.cn>
Subject: Re: [RESEND PATCH v4 -next] tty: serial: add panic serial helper

在 2023/6/16 14:03, Greg KH 写道:
> On Fri, Jun 16, 2023 at 10:31:15AM +0800, Hongyu Xie wrote:
>> 在 2023/6/15 18:17, Greg KH 写道:
>>> On Wed, Jun 14, 2023 at 10:55:12AM +0800, Hongyu Xie wrote:
>>>> It was inspired by kgdboc.
>>>>
>>>> This is a debug module that allows you to get all kernel logs
>>>> after panic.
>>>>
>>>> Normally you need to attach a USB-to-UART tool or enable kdump
>>>> before panic happens to get log from kernel after panic. If you
>>>> didn't do that and kdump is not working, you can't get any log to
>>>> know what happened before panic. If you have a USB-to-UART tool
>>>> and the UART port on your computer is working. This module helps
>>>> you to get all kernel log after panic() is called.
>>>>
>>>> To use this, see Documentation/dev-tools/panic_serial_helper.rst.
>>>>
>>>> Tested on an arm64 device.
>>>>
>>>> Signed-off-by: Hongyu Xie <xiehongyu1@...inos.cn>
>>>> ---
>>>
>>> Why  is this a RESEND?  What's wrong with the previous version?
>> Nobody review v4 for over a week.
> 
> That's fine, but you need to say _why_ this is being resent, otherwise
> we have no idea, and this just moves to the bottom of our review queue.
"Nobody review v4 for over a week." was the reason. I should resubmit 
the same patch or ping instead of using "RESEND", is that what you mean?

> 
> thanks,
> 
> greg k-h
thanks,

Hongyu Xie