linux-kernel - Re: [PATCH v1] fs:smb:server:Fix unsigned compared with less than zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 16 Jun 2023 15:31:06 +0900
From:   Namjae Jeon <linkinjeon@...nel.org>
To:     Wang Ming <machel@...o.com>
Cc:     Steve French <sfrench@...ba.org>,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        Tom Talpey <tom@...pey.com>, linux-cifs@...r.kernel.org,
        linux-kernel@...r.kernel.org, opensource.kernel@...o.com
Subject: Re: [PATCH v1] fs:smb:server:Fix unsigned compared with less than zero

2023-06-15 15:01 GMT+09:00, Namjae Jeon <linkinjeon@...nel.org>:
> 2023-06-14 21:27 GMT+09:00, Wang Ming <machel@...o.com>:
>> The return value of the ksmbd_vfs_getcasexattr() is long.
>> However, the return value is being assigned to an unsignef
>> long variable 'v_len',so making 'v_len' to long.
>>
>> silence the warning:
>> ./fs/smb/server/vfs.c:433:6-11:WARNING: Unsigned expression compared
>> with zero: v_len > 0
>>
>> Signed-off-by: Wang Ming <machel@...o.com>
> Acked-by: Namjae Jeon <linkinjeon@...nel.org>
Hi Wang,

Your patch seems to be corrupted.

ERROR: patch seems to be corrupt (line wrapped?)
#107: FILE: fs/smb/server/vfs.c:399:
, char *buf, loff_t *pos,

WARNING: please, no spaces at the start of a line
#112: FILE: fs/smb/server/vfs.c:403:
+       size_t size;$

WARNING: please, no spaces at the start of a line
#113: FILE: fs/smb/server/vfs.c:404:
+       ssize_t v_len;$

WARNING: please, no spaces at the start of a line
#123: FILE: fs/smb/server/vfs.c:421:
+       if (v_len < 0) {$

WARNING: suspect code indent for conditional statements (7, 15)
#123: FILE: fs/smb/server/vfs.c:421:
+       if (v_len < 0) {
                pr_err("not found stream in xattr : %zd\n", v_len);

total: 1 errors, 4 warnings, 19 lines checked

Can you send the patch using git send-email or attach the patch file
on this mail ?
>
> Thanks!
>