linux-kernel - RE: [EXT] Re: [PATCH 1/8] ethosu: Add Arm Ethos-U driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM9PR04MB890708494C6FBC3FC0DE63CFF458A@AM9PR04MB8907.eurprd04.prod.outlook.com>
Date:   Fri, 16 Jun 2023 08:28:59 +0000
From:   Alison Wang <alison.wang@....com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Leo Li <leoyang.li@....com>, Forrest Shi <xuelin.shi@....com>,
        "X.F. Ren" <xiaofeng.ren@....com>, Feng Guo <feng.guo@....com>
Subject: RE: [EXT] Re: [PATCH 1/8] ethosu: Add Arm Ethos-U driver

On Fri, Jun 16, 2023 at 01:59:06PM +0800, Alison Wang wrote:
> +static int ethosu_buffer_release(struct inode *inode,
> +                              struct file *file) {
> +     struct ethosu_buffer *buf = file->private_data;
> +
> +     dev_info(buf->edev->dev, "Buffer release. handle=0x%pK\n", buf);

Oh, and please remove your debugging code that you have here, and all over the place in the driver.  When drivers work properly, they are quiet, NOT printing out to the information log.

Are you sure that all of those people reviewed this thing?
[Alison Wang] These codes are also written by Arm guys. I changed dev_info to dev_dbg in the later patches.
Ok, I will remove these code.

Thanks a lot for your review.

greg k-h