linux-kernel - Re: [PATCH] md/raid1-10: shut up randstruct warning again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1d2ea39d-e909-f0b2-0ff8-979ca35f16e9@huaweicloud.com>
Date:   Fri, 16 Jun 2023 17:30:30 +0800
From:   Yu Kuai <yukuai1@...weicloud.com>
To:     Arnd Bergmann <arnd@...nel.org>, Song Liu <song@...nel.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Damien Le Moal <damien.lemoal@...nsource.wdc.com>,
        Jens Axboe <axboe@...nel.dk>,
        Johannes Thumshirn <johannes.thumshirn@....com>,
        linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org,
        "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH] md/raid1-10: shut up randstruct warning again

Hi,

在 2023/06/16 17:24, Arnd Bergmann 写道:
> From: Arnd Bergmann <arnd@...db.de>
> 
> A code reorganization brought back a warning when structure randomization
> is enabled:
> 
> drivers/md/raid1-10.c:119:25: error: casting from randomized structure pointer type 'struct block_device *' to 'struct md_rdev *'
>          struct md_rdev *rdev = (struct md_rdev *)bio->bi_bdev;
>                                 ^
> 
> Before the rework, this used a (void*) cast, so go back to that in order
> to avoid the warning. Casting between pointers to incompatible types is
> clearly something that is dangerous, but this driver has always done so,
> and it's not made any worse by the struct randomization in this case.
> 
> Fixes: 8295efbe68c08 ("md/raid1-10: factor out a helper to submit normal write")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks for the patch, and this problem is already reported by kernel
test robot:

https://lore.kernel.org/oe-kbuild-all/202306142042.fmjfmTF8-lkp@intel.com/

And fixed patch is already applied:

https://lore.kernel.org/lkml/CAPhsuW6aSvCEa1khjjmDYGozUEs+Tx75RxfaE1+xL2Y1T6aN=Q@mail.gmail.com/T/

Thanks,
Kuai
> ---
>   drivers/md/raid1-10.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/md/raid1-10.c b/drivers/md/raid1-10.c
> index 169ebe296f2d0..3f22edec70e78 100644
> --- a/drivers/md/raid1-10.c
> +++ b/drivers/md/raid1-10.c
> @@ -116,7 +116,7 @@ static void md_bio_reset_resync_pages(struct bio *bio, struct resync_pages *rp,
>   
>   static inline void raid1_submit_write(struct bio *bio)
>   {
> -	struct md_rdev *rdev = (struct md_rdev *)bio->bi_bdev;
> +	struct md_rdev *rdev = (void *)bio->bi_bdev;
>   
>   	bio->bi_next = NULL;
>   	bio_set_dev(bio, rdev->bdev);
>