linux-kernel - Re: [PATCH v3 09/21] KVM:x86: Load guest FPU state when accessing xsaves-managed MSRs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <91a2447a-9d4b-1e2c-6925-86b1035ffee7@intel.com>
Date:   Fri, 16 Jun 2023 10:02:08 +0800
From:   "Yang, Weijiang" <weijiang.yang@...el.com>
To:     Sean Christopherson <seanjc@...gle.com>
CC:     <pbonzini@...hat.com>, <kvm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <peterz@...radead.org>,
        <rppt@...nel.org>, <binbin.wu@...ux.intel.com>,
        <rick.p.edgecombe@...el.com>, <john.allen@....com>,
        Sean Christopherson <sean.j.christopherson@...el.com>
Subject: Re: [PATCH v3 09/21] KVM:x86: Load guest FPU state when accessing
 xsaves-managed MSRs


On 6/16/2023 7:50 AM, Sean Christopherson wrote:
> On Thu, May 11, 2023, Yang Weijiang wrote:
>> From: Sean Christopherson <sean.j.christopherson@...el.com>
>>
>> Load the guest's FPU state if userspace is accessing MSRs whose values are
>> managed by XSAVES. Two MSR access helpers, i.e., kvm_{get,set}_xsave_msr(),
>> are introduced by a later patch to facilitate access to this kind of MSRs.
>>
>>
>> [...]
>>   
>>   #define KVM_X86_OP(func)					     \
>> @@ -4336,6 +4339,21 @@ int kvm_get_msr_common(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
>>   }
>>   EXPORT_SYMBOL_GPL(kvm_get_msr_common);
>>   
>> +static const u32 xsave_msrs[] = {
> Can you change this to "xstate_msrs"?
OK, will change it in next version.
>
>
>> +	MSR_IA32_U_CET, MSR_IA32_PL3_SSP,
>> +};
>> +
>> +static bool is_xsaves_msr(u32 index)
> And then is_xstate_msr().  The intent to is check if an MSR is managed as part of
> the xstate, not if the MSR is somehow related to XSAVE itself.
Make sense, will change it. Thanks!