linux-kernel - [PATCH -next] ext4: Remove used function ext4_journal_callback_try

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20230616101504.32520-1-yuehaibing@huawei.com>
Date:   Fri, 16 Jun 2023 18:15:04 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     <tytso@....edu>, <adilger.kernel@...ger.ca>,
        <changfengnan@...edance.com>, <yuehaibing@...wei.com>
CC:     <linux-ext4@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: [PATCH -next] ext4: Remove used function ext4_journal_callback_try_del()

commit a015434480dc ("ext4: send parallel discards on commit completions")
removed its last caller so drop it.

Signed-off-by: YueHaibing <yuehaibing@...wei.com>
---
 fs/ext4/ext4_jbd2.h | 21 ---------------------
 1 file changed, 21 deletions(-)

diff --git a/fs/ext4/ext4_jbd2.h b/fs/ext4/ext4_jbd2.h
index 0c77697d5e90..33b9d328ca9e 100644
--- a/fs/ext4/ext4_jbd2.h
+++ b/fs/ext4/ext4_jbd2.h
@@ -185,27 +185,6 @@ static inline void ext4_journal_callback_add(handle_t *handle,
 	spin_unlock(&sbi->s_md_lock);
 }
 
-
-/**
- * ext4_journal_callback_del: delete a registered callback
- * @handle: active journal transaction handle on which callback was registered
- * @jce: registered journal callback entry to unregister
- * Return true if object was successfully removed
- */
-static inline bool ext4_journal_callback_try_del(handle_t *handle,
-					     struct ext4_journal_cb_entry *jce)
-{
-	bool deleted;
-	struct ext4_sb_info *sbi =
-			EXT4_SB(handle->h_transaction->t_journal->j_private);
-
-	spin_lock(&sbi->s_md_lock);
-	deleted = !list_empty(&jce->jce_list);
-	list_del_init(&jce->jce_list);
-	spin_unlock(&sbi->s_md_lock);
-	return deleted;
-}
-
 int
 ext4_mark_iloc_dirty(handle_t *handle,
 		     struct inode *inode,
-- 
2.34.1