linux-kernel - Re: [PATCH v4 2/2] crypto: hisilicon/advca

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 16 Jun 2023 18:58:03 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     David Yang <mmyangfl@...il.com>
Cc:     linux-crypto@...r.kernel.org, Weili Qian <qianweili@...wei.com>,
        Zhou Wang <wangzhou1@...ilicon.com>,
        "David S. Miller" <davem@...emloft.net>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/2] crypto: hisilicon/advca - Add SHA support

On Tue, Jun 06, 2023 at 03:11:12PM +0800, David Yang wrote:
.
> +/*
> + * must be called before setting SHA_START
> + * does nothing if import is not supported (SHA_TYPE_HASH)
> + */
> +static void hica_sha_import(const struct hica_sha_priv *priv, const void *state)
> +{
> +	if (priv->type != SHA_TYPE_MHASH)
> +		return;

As you may have noticed from the void return type, an import is
not allowed to fail.  If you have to fail then you're doing something
wrong.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt