[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZIxd/kINrMLfZ8cD@kernel.org>
Date: Fri, 16 Jun 2023 10:05:02 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Vincent Whitchurch <Vincent.Whitchurch@...s.com>
Cc: "peterz@...radead.org" <peterz@...radead.org>,
"mingo@...hat.com" <mingo@...hat.com>,
"jolsa@...nel.org" <jolsa@...nel.org>,
"namhyung@...nel.org" <namhyung@...nel.org>,
"linux-perf-users@...r.kernel.org" <linux-perf-users@...r.kernel.org>,
"mark.rutland@....com" <mark.rutland@....com>,
kernel <kernel@...s.com>,
"alexander.shishkin@...ux.intel.com"
<alexander.shishkin@...ux.intel.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] perf annotate: Work with vmlinux outside symfs
Em Fri, Jun 16, 2023 at 10:21:52AM +0000, Vincent Whitchurch escreveu:
> On Fri, 2022-11-25 at 12:42 +0100, Vincent Whitchurch wrote:
> > It is currently possible to use --symfs along with a vmlinux which lies
> > outside of the symfs by passing an absolute path to --vmlinux, thanks to
> > the check in dso__load_vmlinux() which handles this explicitly.
> >
> > However, the annotate code lacks this check and thus perf annotate does
> > not work ("Internal error: Invalid -1 error code") for kernel functions
> > with this combination. Add the missing handling.
> >
> > Signed-off-by: Vincent Whitchurch <vincent.whitchurch@...s.com>
>
> This patch was not merged and I did not receive any comments on it
> either. Should I resend it? It still applies cleanly to current
> mainline. Thanks.
Thanks for the ping, I checked dso__load_vmlinux() and it has:
if (vmlinux[0] == '/')
snprintf(symfs_vmlinux, sizeof(symfs_vmlinux), "%s", vmlinux);
else
symbol__join_symfs(symfs_vmlinux, vmlinux)
Exactly as you pointed out, applied.
- Arnaldo
Powered by blists - more mailing lists