linux-kernel - Re: [PATCH v6 3/6] media: starfive: Add basic driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa665e61-f36a-5f65-4837-8d7c8c6a052e@linaro.org>
Date:   Fri, 16 Jun 2023 14:13:03 +0100
From:   Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To:     Jack Zhu <jack.zhu@...rfivetech.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Robert Foss <rfoss@...nel.org>,
        Todor Tomov <todor.too@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Eugen Hristev <eugen.hristev@...labora.com>,
        Ezequiel Garcia <ezequiel@...guardiasur.com.ar>
Cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, changhuang.liang@...rfivetech.com
Subject: Re: [PATCH v6 3/6] media: starfive: Add basic driver

On 25/05/2023 09:31, Jack Zhu wrote:
> Add basic platform driver for StarFive Camera Subsystem.
> 
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
> Signed-off-by: Jack Zhu <jack.zhu@...rfivetech.com>

One thing here is the patch title and hence commit message.

"media: starfive:" doesn't really tell you this is a camera versus say a 
encoder/decoder.

I see you've used the name "camss" for your driver, which I think is a 
perfectly good and logical choice - however if you started to make 
commits along the lines of "media: camss" that would conflict with the 
qcom camss.

How about for starfive and qcom by the way, we do what Laurent did in

commit 3e8537b4c15172bfe1b285c3155ed5c37d523cd3
Author: Laurent Pinchart <laurent.pinchart@...asonboard.com>
Date:   Wed Dec 21 10:33:39 2022 +0100

     media: ti: omap3isp: Use media_pipeline_for_each_entity()

i.e. future StarFive commits for camera would be "media: starfive: 
camss" and similarly for Qualcomm "media: qualcomm: camss"

The point being the commit title namespace should be instructive and 
specific re: 3e8537b4c15172bfe1b285c3155ed5c37d523cd3

---
bod