linux-kernel - Re: [PATCH] drm/bridge: lt9611uxc: Add MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAN6tsi4jdDD20DY5sKL+ALC_Mk2UHRArOrQnjzKoyF30QZi8jw@mail.gmail.com>
Date:   Fri, 16 Jun 2023 15:47:29 +0200
From:   Robert Foss <rfoss@...nel.org>
To:     Juerg Haefliger <juerg.haefliger@...onical.com>
Cc:     andrzej.hajda@...el.com, neil.armstrong@...aro.org,
        Laurent.pinchart@...asonboard.com, jonas@...boo.se,
        jernej.skrabec@...il.com, airlied@...il.com, daniel@...ll.ch,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/bridge: lt9611uxc: Add MODULE_FIRMWARE macro

On Fri, Jun 16, 2023 at 2:13 PM Juerg Haefliger
<juerg.haefliger@...onical.com> wrote:
>
> The module loads firmware so add a MODULE_FIRMWARE macro to provide that
> information via modinfo.
>
> Signed-off-by: Juerg Haefliger <juerg.haefliger@...onical.com>
> ---
>  drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> index 583daacf3705..6b2a4f8d6f78 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> @@ -1019,3 +1019,5 @@ module_i2c_driver(lt9611uxc_driver);
>
>  MODULE_AUTHOR("Dmitry Baryshkov <dmitry.baryshkov@...aro.org>");
>  MODULE_LICENSE("GPL v2");
> +
> +MODULE_FIRMWARE("lt9611uxc_fw.bin");
> --
> 2.37.2
>

Can filename string be made into a macro, as it is used in two locations?

With that fixed, please add my r-b.


Rob.