linux-kernel - Re: [PATCH v1 1/1] gpiolib: Drop unused domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbPEvVvaehB521gdjkkzh+wFnFxsCNm36PD-hnTb1Na_w@mail.gmail.com>
Date:   Sat, 17 Jun 2023 11:08:10 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Marc Zyngier <maz@...nel.org>,
        Thierry Reding <treding@...dia.com>
Cc:     Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Bartosz Golaszewski <brgl@...ev.pl>,
        Andy Shevchenko <andy@...nel.org>
Subject: Re: [PATCH v1 1/1] gpiolib: Drop unused domain_ops memeber of GPIO
 IRQ chip

On Fri, Jun 16, 2023 at 3:53 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:

> It seems there is no driver that requires custom IRQ chip
> domain options. Drop the member and respective code.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
(...)
> -               /* Some drivers provide custom irqdomain ops */
>                 gc->irq.domain = irq_domain_create_simple(fwnode,
>                         gc->ngpio,
>                         gc->irq.first,
> -                       gc->irq.domain_ops ?: &gpiochip_domain_ops,
> +                       &gpiochip_domain_ops,

We better run this by Marc Zyngier, and Thierry who introduced it.

But some grepping and looking seems to conclude you are righ!
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij