linux-kernel - Re: [PATCH V5 0/2] irqchip: loongson-eiointc: Add DT init support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <03c3df36-203b-591e-c0bb-05bfde54be77@gmail.com>
Date:   Sat, 17 Jun 2023 10:13:26 +0800
From:   Binbin Zhou <zhoubb.aaron@...il.com>
To:     Huacai Chen <chenhuacai@...nel.org>,
        WANG Xuerui <kernel@...0n.name>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Marc Zyngier <maz@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc:     Jianmin Lv <lvjianmin@...ngson.cn>,
        Huacai Chen <chenhuacai@...ngson.cn>,
        linux-kernel@...r.kernel.org, loongarch@...ts.linux.dev,
        devicetree@...r.kernel.org, loongson-kernel@...ts.loongnix.cn,
        zhoubinbin@...ngson.cn
Subject: Re: [PATCH V5 0/2] irqchip: loongson-eiointc: Add DT init support

Hi Marc:

The dt-binding part of the patchset looks good now, do you have any more 
comments on the driver part?

Thanks.
Binbin

On 2023/5/5 17:46, Binbin Zhou wrote:
> Hi all:
>
> Add EIOINTC irqchip DT support, which is needed for Loongson chips
> that are DT-based and support EIOINTC, such as the Loongson-2K0500 chip.
>
> Thanks.
>
> ---
> V5:
> - patch(2/2)
>    - Rebased on top of latest loongarch-next(v6.3.0).
>
> V4:
> - patch(1/2)
>    - Simplify the definition of the reg attribute by declaring the entire
>      chip configuration space directly.
>
> V3:
> - patch(1/2)
>    - Drop quotes;
>    - Drop interrupt-names;
>    - Drop loongson,eio-num-vecs;
>    - SoC-based compatibles instead of version-based compatibles.
> - patch (2/2)
>    - irq_set_handler_data() is used to get parent irq form DTS;
>    - Set vec_count by judging compatibles.
>
> V2:
> - Add the dt-bindings file (1/2);
> - patch(2/2)
>    - Remove forgotten debugging messages;
>    - Change compatible string name to "loongson,eiointc-1.0".
>
> Binbin Zhou (2):
>    dt-bindings: interrupt-controller: Add Loongson EIOINTC
>    irqchip/loongson-eiointc: Add DT init support
>
>   .../loongson,eiointc.yaml                     |  59 ++++++++
>   drivers/irqchip/irq-loongson-eiointc.c        | 133 +++++++++++++-----
>   2 files changed, 157 insertions(+), 35 deletions(-)
>   create mode 100644 Documentation/devicetree/bindings/interrupt-controller/loongson,eiointc.yaml
>