linux-kernel - Re: [PATCH v2 07/11] kbuild: rust_is_available: fix confusion when a version appears in the path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <CTF19P8FLNUZ.3OA1ANA7IUG87@hackbook>
Date:   Sat, 17 Jun 2023 10:33:51 -0500
From:   "Ethan D. Twardy" <ethan.twardy@...il.com>
To:     "Miguel Ojeda" <ojeda@...nel.org>,
        "Masahiro Yamada" <masahiroy@...nel.org>,
        "Wedson Almeida Filho" <wedsonaf@...il.com>,
        "Alex Gaynor" <alex.gaynor@...il.com>
Cc:     "Nathan Chancellor" <nathan@...nel.org>,
        "Nick Desaulniers" <ndesaulniers@...gle.com>,
        "Nicolas Schier" <nicolas@...sle.eu>,
        "Boqun Feng" <boqun.feng@...il.com>, "Gary Guo" <gary@...yguo.net>,
        Björn Roy Baron <bjorn3_gh@...tonmail.com>,
        "Benno Lossin" <benno.lossin@...ton.me>,
        "Alice Ryhl" <aliceryhl@...gle.com>,
        "Andreas Hindborg" <nmi@...aspace.dk>,
        <linux-kbuild@...r.kernel.org>, <rust-for-linux@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <patches@...ts.linux.dev>,
        "Jordan Isaacs" <mail@...saacs.com>,
        "Tiago Lam" <tiagolam@...il.com>
Subject: Re: [PATCH v2 07/11] kbuild: rust_is_available: fix confusion when
 a version appears in the path

On Thu Jun 15, 2023 at 7:16 PM CDT, Miguel Ojeda wrote:
> ---
>  scripts/rust_is_available.sh | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/scripts/rust_is_available.sh b/scripts/rust_is_available.sh
> index 7e0368babe64..810691af66eb 100755
> --- a/scripts/rust_is_available.sh
> +++ b/scripts/rust_is_available.sh
> @@ -157,9 +157,7 @@ fi
>  # of the `libclang` found by the Rust bindings generator is suitable.
>  bindgen_libclang_version=$( \
>  	echo "$bindgen_libclang_output" \
> -		| grep -F 'clang version ' \
> -		| grep -oE '[0-9]+\.[0-9]+\.[0-9]+' \
> -		| head -n 1 \
> +		| sed -nE 's:.*clang version ([0-9]+\.[0-9]+\.[0-9]+).*:\1:p'
>  )
>  bindgen_libclang_min_version=$($min_tool_version llvm)
>  bindgen_libclang_cversion=$(get_canonical_version $bindgen_libclang_version)

Reviewed-By: Ethan Twardy <ethan.twardy@...il.com>
Tested-By: Ethan Twardy <ethan.twardy@...il.com>