lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20230617210658.43d5b787@jic23-huawei>
Date:   Sat, 17 Jun 2023 21:06:58 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Maxim Kiselev <bigunclemax@...il.com>
Cc:     linux-iio@...r.kernel.org,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Samuel Holland <samuel@...lland.org>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Cristian Ciocaltea <cristian.ciocaltea@...labora.com>,
        Heiko Stuebner <heiko.stuebner@...ll.eu>,
        Cosmin Tanislav <demonsingur@...il.com>,
        Haibo Chen <haibo.chen@....com>,
        Leonard Göhrs <l.goehrs@...gutronix.de>,
        Caleb Connolly <caleb.connolly@...aro.org>,
        Hugo Villeneuve <hvilleneuve@...onoff.com>,
        Mike Looijmans <mike.looijmans@...ic.nl>,
        ChiYuan Huang <cy_huang@...htek.com>,
        Ramona Bolboaca <ramona.bolboaca@...log.com>,
        Ibrahim Tilki <Ibrahim.Tilki@...log.com>,
        William Breathitt Gray <william.gray@...aro.org>,
        Arnd Bergmann <arnd@...db.de>,
        ChiaEn Wu <chiaen_wu@...htek.com>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
        linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v7 1/3] iio: adc: Add Allwinner D1/T113s/R329/T507 SoCs
 GPADC

On Sat, 17 Jun 2023 21:52:12 +0300
Maxim Kiselev <bigunclemax@...il.com> wrote:

> сб, 17 июн. 2023 г. в 16:49, Jonathan Cameron <jic23@...nel.org>:
> >
> > On Thu, 15 Jun 2023 23:55:20 +0300
> > Maksim Kiselev <bigunclemax@...il.com> wrote:
> >  
> > > The General Purpose ADC (GPADC) can convert the external signal into
> > > a certain proportion of digital value, to realize the measurement of
> > > analog signal, which can be applied to power detection and key detection.
> > >
> > > Theoretically, this ADC can support up to 16 channels. All SoCs below
> > > contain this GPADC IP. The only difference between them is the number
> > > of available channels:
> > >
> > >  T113 - 1 channel
> > >  D1   - 2 channels
> > >  R329 - 4 channels
> > >  T507 - 4 channels
> > >
> > > Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
> > > Signed-off-by: Maksim Kiselev <bigunclemax@...il.com>
> > > ---
> > >  drivers/iio/adc/Kconfig            |  10 ++
> > >  drivers/iio/adc/Makefile           |   1 +
> > >  drivers/iio/adc/sun20i-gpadc-iio.c | 276 +++++++++++++++++++++++++++++
> > >  3 files changed, 287 insertions(+)
> > >  create mode 100644 drivers/iio/adc/sun20i-gpadc-iio.c
> > >
> > > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> > > index eb2b09ef5d5b..deff7ae704ce 100644
> > > --- a/drivers/iio/adc/Kconfig
> > > +++ b/drivers/iio/adc/Kconfig
> > > @@ -1123,6 +1123,16 @@ config SUN4I_GPADC
> > >         To compile this driver as a module, choose M here: the module will be
> > >         called sun4i-gpadc-iio.
> > >
> > > +config SUN20I_GPADC
> > > +     tristate "Support for the Allwinner SoCs GPADC"  
> > I applied this and started a build test before noticing that this Kconfig description
> > is very vague and matches the one for the existing 4i driver...  
> 
> Indeed. I must have forgotten to change this line when copying from sun4i...
> 
> > The 'Support for the' bit also isn't appropriate for what you see in make menuconfig
> > menu etc.   Please come up with something descriptive. Maybe
> > "sun20i and similar SoC GPADC"?
> >
> > Bonus points if you change the text for the 4i at the same time to be
> > more meaningful. I clearly missed that in review a long time ago!  
> 
> Should I do this in a separate patch?
Yes please.

Thanks,

Jonathan


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ