linux-kernel - Re: [PATCHv2 1/2] dt-bindings: arm: rockchip: Add Firefly Station P2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 17 Jun 2023 22:44:19 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Conor Dooley <conor@...nel.org>,
        Furkan Kardame <f.kardame@...jaro.org>
Cc:     robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org, heiko@...ech.de, broonie@...nel.org,
        deller@....de, dsterba@...e.com, arnd@...db.de,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2 1/2] dt-bindings: arm: rockchip: Add Firefly Station P2

On 17/06/2023 22:40, Conor Dooley wrote:
> Hey Furkan,
> 
> On Sat, Jun 17, 2023 at 04:53:14PM +0300, Furkan Kardame wrote:
>> Station P2 is a single board computer by firefly based
>> on rk3568 soc
>>
>> Signed-off-by: Furkan Kardame <f.kardame@...jaro.org>
>> ---
>>  Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> index ec141c937..fa21640bc 100644
>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> @@ -185,6 +185,11 @@ properties:
>>            - const: firefly,rk3566-roc-pc
>>            - const: rockchip,rk3566
>>  
>> +      - description: Firefly Station P2
>> +	items:
>> +	  - const: firefly,rk3568-roc-pc
>> +	  - const: rockchip,rk3568
> 
> yaml files are indented with spaces, not tabs.
> 

Which is pointed out by testing, so this was not tested :(

Please run `make dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Maybe you need to update your dtschema and yamllint.

Best regards,
Krzysztof