linux-kernel - Re: [PATCH V2] ptp: clockmatrix: Add Defer probe if firmware load fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <ZI5VxN8o+VvwrZ+5@vcheng-VirtualBox>
Date:   Sat, 17 Jun 2023 20:54:28 -0400
From:   Vincent Cheng <vscheng@...il.com>
To:     Sarath Babu Naidu Gaddam <sarath.babu.naidu.gaddam@....com>,
        richardcochran@...il.com, netdev@...r.kernel.org
Cc:     simon.horman@...igine.com, andrew@...n.ch,
        linux-kernel@...r.kernel.org, harini.katakam@....com, git@....com
Subject: Re: [PATCH V2] ptp: clockmatrix: Add Defer probe if firmware load
 fails

On Sun, Jun 18, 2023 at 12:51:08AM +0000, Vincent Cheng wrote:
> 
> 
> -----Original Message-----
> From: Sarath Babu Naidu Gaddam <sarath.babu.naidu.gaddam@....com> 
> Sent: Wednesday, June 14, 2023 1:12 AM
> To: richardcochran@...il.com; netdev@...r.kernel.org
> Cc: simon.horman@...igine.com; andrew@...n.ch; linux-kernel@...r.kernel.org; Vincent Cheng <vincent.cheng.xh@...esas.com>; harini.katakam@....com; git@....com; sarath.babu.naidu.gaddam@....com
> Subject: [PATCH V2] ptp: clockmatrix: Add Defer probe if firmware load fails
> 
> Clock matrix driver can be probed before the rootfs containing firmware/initialization .bin is available. The current driver throws a warning and proceeds to execute probe even when firmware is not ready. Instead, defer probe and wait for the .bin file to be available.
> 
> Signed-off-by: Sarath Babu Naidu Gaddam <sarath.babu.naidu.gaddam@....com>

Reviewed-by: Vincent Cheng <vincent.cheng.xh@...esas.com>

> ---
> Changes in V2:
> 1) Added mutex_unlock(idtcm->lock); before returning EPROBE_DEFER.
> 2) Moved failure log after defer probe.
> ---
>  drivers/ptp/ptp_clockmatrix.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/ptp/ptp_clockmatrix.c b/drivers/ptp/ptp_clockmatrix.c index c9d451bf89e2..b3cb136257e3 100644
> --- a/drivers/ptp/ptp_clockmatrix.c
> +++ b/drivers/ptp/ptp_clockmatrix.c
> @@ -2424,8 +2424,13 @@ static int idtcm_probe(struct platform_device *pdev)
>  
>  	err = idtcm_load_firmware(idtcm, &pdev->dev);
>  
> -	if (err)
> +	if (err) {
> +		if (err == -ENOENT) {
> +			mutex_unlock(idtcm->lock);
> +			return -EPROBE_DEFER;
> +		}
>  		dev_warn(idtcm->dev, "loading firmware failed with %d", err);
> +	}
>  
>  	wait_for_chip_ready(idtcm);
>  
> --
> 2.25.1
>