linux-kernel - Re: [PATCH 1/2] dt-bindings: leds: Add Kinetic KTD2026/2027 LED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7cbc6572-6772-64a6-6c91-567d58286426@linaro.org>
Date:   Sun, 18 Jun 2023 14:41:52 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     André Apitzsch <git@...tzsch.eu>,
        Pavel Machek <pavel@....cz>, Lee Jones <lee@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>
Cc:     linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH 1/2] dt-bindings: leds: Add Kinetic KTD2026/2027 LED

On 18/06/2023 13:45, André Apitzsch wrote:
> Document Kinetic KTD2026/2027 LED driver devicetree bindings.
> 
> Signed-off-by: André Apitzsch <git@...tzsch.eu>
> ---
>  .../devicetree/bindings/leds/leds-ktd202x.yaml     | 164 +++++++++++++++++++++
>  1 file changed, 164 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/leds/leds-ktd202x.yaml b/Documentation/devicetree/bindings/leds/leds-ktd202x.yaml
> new file mode 100644
> index 000000000000..9868d6f6f147
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-ktd202x.yaml

Filename matching compatible, so missing vendor prefix. Can be
kinetic,ktd202x.yaml

> @@ -0,0 +1,164 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/leds-ktd202x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Kinetic KTD2026/7 RGB/White LED Driver

Driver stands for Linux driver or for driving a LED? If the first, then
drop.


The rest looks good, so you just need to use proper filename.

Best regards,
Krzysztof