[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZI8xmZqmyHF0jhBg@chenyu5-mobl2.ccr.corp.intel.com>
Date: Mon, 19 Jun 2023 00:32:25 +0800
From: Chen Yu <yu.c.chen@...el.com>
To: Miaohe Lin <linmiaohe@...wei.com>
CC: <mingo@...hat.com>, <peterz@...radead.org>,
<juri.lelli@...hat.com>, <vincent.guittot@...aro.org>,
<dietmar.eggemann@....com>, <rostedt@...dmis.org>,
<bsegall@...gle.com>, <mgorman@...e.de>, <bristot@...hat.com>,
<vschneid@...hat.com>, <linux-kernel@...r.kernel.org>,
<tim.c.chen@...el.com>, <ricardo.neri@...el.com>,
<yangyicong@...wei.com>
Subject: Re: [PATCH] sched/topology: remove unneeded do while loop in
cpu_attach_domain()
On 2023-06-17 at 16:19:26 +0800, Miaohe Lin wrote:
> When sg != sd->groups, the do while loop would cause deadloop here. But
> that won't occur because sg is always equal to sd->groups now. Remove
> this unneeded do while loop.
>
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
> ---
> kernel/sched/topology.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
> index ca4472281c28..9010c93c3fdb 100644
> --- a/kernel/sched/topology.c
> +++ b/kernel/sched/topology.c
> @@ -750,10 +750,7 @@ cpu_attach_domain(struct sched_domain *sd, struct root_domain *rd, int cpu)
> * domain for convenience. Clear such flags since
> * the child is being destroyed.
> */
> - do {
> - sg->flags = 0;
I guess we don't need to clear the flag of remote groups for now.
> - } while (sg != sd->groups);
> -
> + sg->flags = 0;
> sd->child = NULL;
> }
> }
> --
> 2.27.0
>
Reviewed-by: Chen Yu <yu.c.chen@...el.com>
thanks,
Chenyu
Powered by blists - more mailing lists