linux-kernel - Re: [PATCH 5/6] tty: serial: meson: Added T7 SOC compatibility

Open Source and information security mailing list archives

Message-ID: <CAJX_Q+3_UME4xigEU+_dXrdLi+YkL0+TC-Y552LBcuTii4=V5w@mail.gmail.com>
Date:   Sun, 18 Jun 2023 18:40:12 +0100
From:   Lucas Tanure <tanure@...ux.com>
To:     Yixun Lan <dlan@...too.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Jerome Brunet <jbrunet@...libre.com>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Kevin Hilman <khilman@...libre.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Nick <nick@...das.com>, Artem <art@...das.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-amlogic@...ts.infradead.org, linux-clk@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH 5/6] tty: serial: meson: Added T7 SOC compatibility

On Fri, Jun 16, 2023 at 12:31 AM Yixun Lan <dlan@...too.org> wrote:
>
> Hi Lucas:
>
> On 19:29 Thu 15 Jun     , Lucas Tanure wrote:
> > Make UART driver compatible with T7 SOC UART.
> >
> > Signed-off-by: Lucas Tanure <tanure@...ux.com>
> > ---
> >  drivers/tty/serial/meson_uart.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
> > index 2501db5a7aaf..0208f9a6ba7e 100644
> > --- a/drivers/tty/serial/meson_uart.c
> > +++ b/drivers/tty/serial/meson_uart.c
> > @@ -796,6 +796,10 @@ static const struct of_device_id meson_uart_dt_match[] = {
> >               .compatible = "amlogic,meson-s4-uart",
> >               .data = (void *)&meson_g12a_uart_data,
> >       },
> > +     {
> > +             .compatible = "amlogic,meson-t7-uart",
> > +             .data = (void *)&meson_g12a_uart_data,
> I think you are trying to follow previous s4 scheme - to introduce a new
> compatible string, while I think it's not necessary or even wrong, this will just
> make the dt_match_list longer but without obvious benefits..
>
> as Conor already raised this question in previous dt-binding patch[4/6],
> how about just using 'amlogic,meson-g12a-uart' which is the first compatible
> introduced.
>
> if people agree, we could also drop 'amlogic,meson-s4-uart' since it use same
> compatible data as gl12a, anyway it should be separated into another patch..
>
> > +     },
> >       { /* sentinel */ },
>
>
> >  };
> >  MODULE_DEVICE_TABLE(of, meson_uart_dt_match);
> > --
> > 2.41.0
> >
> >
> > _______________________________________________
> > linux-amlogic mailing list
> > linux-amlogic@...ts.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-amlogic
>
> --
> Yixun Lan (dlan)
> Gentoo Linux Developer
> GPG Key ID AABEFD55

Yes, I am dropping this patch and using s4 and g12a compatible lines.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives