linux-kernel - Re: [PATCH v3 1/7] mm: zswap: add pool shrinking mechanism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230618052526.GB2417524@google.com>
Date:   Sun, 18 Jun 2023 14:25:26 +0900
From:   Sergey Senozhatsky <senozhatsky@...omium.org>
To:     Yosry Ahmed <yosryahmed@...gle.com>
Cc:     Sergey Senozhatsky <senozhatsky@...omium.org>,
        Domenico Cerasuolo <cerasuolodomenico@...il.com>,
        vitaly.wool@...sulko.com, minchan@...nel.org, linux-mm@...ck.org,
        ddstreet@...e.org, sjenning@...hat.com, nphamcs@...il.com,
        hannes@...xchg.org, akpm@...ux-foundation.org,
        linux-kernel@...r.kernel.org, kernel-team@...a.com
Subject: Re: [PATCH v3 1/7] mm: zswap: add pool shrinking mechanism

On (23/06/17 21:48), Yosry Ahmed wrote:
> > On (23/06/12 11:38), Domenico Cerasuolo wrote:
> > > +static int zswap_reclaim_entry(struct zswap_pool *pool)
> > > +{
> > > +     struct zswap_header *zhdr;
> > > +     struct zswap_entry *entry;
> > > +     struct zswap_tree *tree;
> > > +     pgoff_t swpoffset;
> > > +     int ret;
> > > +
> > > +     /* Get an entry off the LRU */
> > > +     spin_lock(&pool->lru_lock);
> > > +     if (list_empty(&pool->lru)) {
> > > +             spin_unlock(&pool->lru_lock);
> > > +             return -EINVAL;
> > > +     }
> > > +     entry = list_last_entry(&pool->lru, struct zswap_entry, lru);
> > > +     list_del_init(&entry->lru);
> >
> > A quick question: should we zswap_entry_get() here?
> 
> We need to hold the tree lock for that, and the lock ordering is tree
> lock -> lru lock. If we try to grab the tree lock here we may
> deadlock.

We can deadlock doing this?

	lock tree_lock
	lock lru_lock
	list_del_init
	unlock lru_lock
	entry_get
	unlock tree_lock
	writeback