linux-kernel - kernel/trace/trace_eprobe.c:427:1: warning: stack frame size (1424) exceeds limit (1024) in 'process_fetch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 19 Jun 2023 05:19:22 +0800
From:   kernel test robot <lkp@...el.com>
To:     "Masami Hiramatsu (Google)" <mhiramat@...nel.org>
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: kernel/trace/trace_eprobe.c:427:1: warning: stack frame size (1424)
 exceeds limit (1024) in 'process_fetch_insn'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   8c1f0c38b31025f60437215dd27fffc293565fa4
commit: b26a124cbfa80f42bfc4e63e1d5643ca98159d66 tracing/probes: Add symstr type for dynamic events
date:   6 months ago
config: riscv-randconfig-r011-20230619 (https://download.01.org/0day-ci/archive/20230619/202306190512.F00Ve0zD-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
reproduce: (https://download.01.org/0day-ci/archive/20230619/202306190512.F00Ve0zD-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306190512.F00Ve0zD-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> kernel/trace/trace_eprobe.c:427:1: warning: stack frame size (1424) exceeds limit (1024) in 'process_fetch_insn' [-Wframe-larger-than]
     427 | process_fetch_insn(struct fetch_insn *code, void *rec, void *dest,
         | ^
   kernel/trace/trace_eprobe.c:561:13: warning: stack frame size (1584) exceeds limit (1024) in 'eprobe_trigger_func' [-Wframe-larger-than]
     561 | static void eprobe_trigger_func(struct event_trigger_data *data,
         |             ^
   2 warnings generated.
--
>> kernel/trace/trace_uprobe.c:218:1: warning: stack frame size (1440) exceeds limit (1024) in 'process_fetch_insn' [-Wframe-larger-than]
     218 | process_fetch_insn(struct fetch_insn *code, void *rec, void *dest,
         | ^
   1 warning generated.


vim +/process_fetch_insn +427 kernel/trace/trace_eprobe.c

7491e2c442781a Tzvetomir Stoyanov (VMware  2021-08-19  424) 
7491e2c442781a Tzvetomir Stoyanov (VMware  2021-08-19  425) /* Note that we don't verify it, since the code does not come from user space */
7491e2c442781a Tzvetomir Stoyanov (VMware  2021-08-19  426) static int
7491e2c442781a Tzvetomir Stoyanov (VMware  2021-08-19 @427) process_fetch_insn(struct fetch_insn *code, void *rec, void *dest,
7491e2c442781a Tzvetomir Stoyanov (VMware  2021-08-19  428) 		   void *base)
7491e2c442781a Tzvetomir Stoyanov (VMware  2021-08-19  429) {
7491e2c442781a Tzvetomir Stoyanov (VMware  2021-08-19  430) 	unsigned long val;
7491e2c442781a Tzvetomir Stoyanov (VMware  2021-08-19  431) 
6a832ec3d680b3 Steven Rostedt (Google      2022-08-20  432)  retry:
6a832ec3d680b3 Steven Rostedt (Google      2022-08-20  433) 	switch (code->op) {
6a832ec3d680b3 Steven Rostedt (Google      2022-08-20  434) 	case FETCH_OP_TP_ARG:
7491e2c442781a Tzvetomir Stoyanov (VMware  2021-08-19  435) 		val = get_event_field(code, rec);
6a832ec3d680b3 Steven Rostedt (Google      2022-08-20  436) 		break;
6a832ec3d680b3 Steven Rostedt (Google      2022-08-20  437) 	case FETCH_OP_IMM:
6a832ec3d680b3 Steven Rostedt (Google      2022-08-20  438) 		val = code->immediate;
6a832ec3d680b3 Steven Rostedt (Google      2022-08-20  439) 		break;
6a832ec3d680b3 Steven Rostedt (Google      2022-08-20  440) 	case FETCH_OP_COMM:
6a832ec3d680b3 Steven Rostedt (Google      2022-08-20  441) 		val = (unsigned long)current->comm;
6a832ec3d680b3 Steven Rostedt (Google      2022-08-20  442) 		break;
6a832ec3d680b3 Steven Rostedt (Google      2022-08-20  443) 	case FETCH_OP_DATA:
6a832ec3d680b3 Steven Rostedt (Google      2022-08-20  444) 		val = (unsigned long)code->data;
6a832ec3d680b3 Steven Rostedt (Google      2022-08-20  445) 		break;
6a832ec3d680b3 Steven Rostedt (Google      2022-08-20  446) 	case FETCH_NOP_SYMBOL:	/* Ignore a place holder */
6a832ec3d680b3 Steven Rostedt (Google      2022-08-20  447) 		code++;
6a832ec3d680b3 Steven Rostedt (Google      2022-08-20  448) 		goto retry;
6a832ec3d680b3 Steven Rostedt (Google      2022-08-20  449) 	default:
6a832ec3d680b3 Steven Rostedt (Google      2022-08-20  450) 		return -EILSEQ;
6a832ec3d680b3 Steven Rostedt (Google      2022-08-20  451) 	}
6a832ec3d680b3 Steven Rostedt (Google      2022-08-20  452) 	code++;
6a832ec3d680b3 Steven Rostedt (Google      2022-08-20  453) 	return process_fetch_insn_bottom(code, val, dest, base);
7491e2c442781a Tzvetomir Stoyanov (VMware  2021-08-19  454) }
7491e2c442781a Tzvetomir Stoyanov (VMware  2021-08-19  455) NOKPROBE_SYMBOL(process_fetch_insn)
7491e2c442781a Tzvetomir Stoyanov (VMware  2021-08-19  456) 

:::::: The code at line 427 was first introduced by commit
:::::: 7491e2c442781a1860181adb5ab472a52075f393 tracing: Add a probe that attaches to trace events

:::::: TO: Tzvetomir Stoyanov (VMware) <tz.stoyanov@...il.com>
:::::: CC: Steven Rostedt (VMware) <rostedt@...dmis.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki