linux-kernel - Re: [PATCH] ipmi:ssif: Add check for kstrdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZJCFG3o4JL/OL9WU@mail.minyard.net>
Date:   Mon, 19 Jun 2023 11:40:59 -0500
From:   Corey Minyard <minyard@....org>
To:     Jiasheng Jiang <jiasheng@...as.ac.cn>
Cc:     kamlakantp@...vell.com, openipmi-developer@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipmi:ssif: Add check for kstrdup

On Mon, Jun 19, 2023 at 05:28:02PM +0800, Jiasheng Jiang wrote:
> Add check for the return value of kstrdup() and return the error
> if it fails in order to avoid NULL pointer dereference.

Thanks, this is in my next tree.

-corey

> 
> Fixes: c4436c9149c5 ("ipmi_ssif: avoid registering duplicate ssif interface")
> Signed-off-by: Jiasheng Jiang <jiasheng@...as.ac.cn>
> ---
>  drivers/char/ipmi/ipmi_ssif.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c
> index 3b921c78ba08..3b87a2726e99 100644
> --- a/drivers/char/ipmi/ipmi_ssif.c
> +++ b/drivers/char/ipmi/ipmi_ssif.c
> @@ -1600,6 +1600,11 @@ static int ssif_add_infos(struct i2c_client *client)
>  	info->addr_src = SI_ACPI;
>  	info->client = client;
>  	info->adapter_name = kstrdup(client->adapter->name, GFP_KERNEL);
> +	if (!info->adapter_name) {
> +		kfree(info);
> +		return -ENOMEM;
> +	}
> +
>  	info->binfo.addr = client->addr;
>  	list_add_tail(&info->link, &ssif_infos);
>  	return 0;
> -- 
> 2.25.1
>