linux-kernel - Re: [PATCH 4/4] ARM: dts: qcom: msm8960: drop spi-max-frequency from controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4658b5c2-3140-2071-391f-1f8af722aa53@linaro.org>
Date:   Mon, 19 Jun 2023 19:16:18 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] ARM: dts: qcom: msm8960: drop spi-max-frequency from
 controller

On 19.06.2023 19:01, Krzysztof Kozlowski wrote:
> spi-max-frequency is a property of SPI device, not SPI controller.  Drop
> it from the controller nodes.  No functional impact expected, although
> qcom-msm8960-samsung-expressatt board does not have any child SPI
> devices thus the property disappears.  This fixes dtbs_check warnings
> like:
> 
>   qcom-msm8960-cdp.dtb: spi@...80000: Unevaluated properties are not allowed ('spi-max-frequency' was unexpected)
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad
>  arch/arm/boot/dts/qcom-msm8960.dtsi | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom-msm8960.dtsi
> index fa2013388d99..d13080fcbeea 100644
> --- a/arch/arm/boot/dts/qcom-msm8960.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8960.dtsi
> @@ -364,7 +364,6 @@ gsbi1_spi: spi@...80000 {
>  				#size-cells = <0>;
>  				reg = <0x16080000 0x1000>;
>  				interrupts = <GIC_SPI 147 IRQ_TYPE_LEVEL_HIGH>;
> -				spi-max-frequency = <24000000>;
>  				cs-gpios = <&msmgpio 8 0>;
>  
>  				clocks = <&gcc GSBI1_QUP_CLK>, <&gcc GSBI1_H_CLK>;