linux-kernel - Re: [PATCH v2 2/2] sched: add throttled time stat for throttled children

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <rs46fzspb2w46zcbgdjysqd2rcfqs4yk55xyf5syvnf75rjhfe@ku6i5chn5qrq>
Date:   Mon, 19 Jun 2023 19:53:11 +0200
From:   Michal Koutný <mkoutny@...e.com>
To:     Josh Don <joshdon@...gle.com>
Cc:     Tejun Heo <tj@...nel.org>, Zefan Li <lizefan.x@...edance.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Juri Lelli <juri.lelli@...hat.com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
        Daniel Bristot de Oliveira <bristot@...hat.com>,
        Valentin Schneider <vschneid@...hat.com>,
        cgroups@...r.kernel.org, linux-kernel@...r.kernel.org,
        Xiangling Kong <xiangling@...gle.com>
Subject: Re: [PATCH v2 2/2] sched: add throttled time stat for throttled
 children

On Mon, Jun 12, 2023 at 04:27:48PM -0700, Josh Don <joshdon@...gle.com> wrote:
> We currently export the total throttled time for cgroups that are given
> a bandwidth limit.

I assume you refer to cpu.stat:throttled_usec (from struct
cfs_bandwidth) -- notice that the value is not properly hierarchical
despite v2 filename.

> This patch extends this accounting to also account the total time that
> each children cgroup has been throttled.

IIUC, this is visible on inner-nodes cpu cgroups (i.e. with no tasks)?

IOW, wouldn't you get the intended information if hierarchical summing
was added/fixed for cpu.stat:throttled_usec?

Thanks,
Michal

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)