[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230619-ion-decree-c63d2eb11e83@spud>
Date: Mon, 19 Jun 2023 21:18:25 +0100
From: Conor Dooley <conor@...nel.org>
To: Dario Binacchi <dario.binacchi@...rulasolutions.com>
Cc: linux-kernel@...r.kernel.org,
Philippe Cornu <philippe.cornu@...s.st.com>,
Raphael Gallais-Pou <raphael.gallais-pou@...s.st.com>,
Amarula patchwork <linux-amarula@...rulasolutions.com>,
michael@...rulasolutions.com,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Conor Dooley <conor+dt@...nel.org>,
Daniel Vetter <daniel@...ll.ch>,
David Airlie <airlied@...il.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Rob Herring <robh+dt@...nel.org>,
Yannick Fertre <yannick.fertre@...s.st.com>,
devicetree@...r.kernel.org, dri-devel@...ts.freedesktop.org,
linux-arm-kernel@...ts.infradead.org,
linux-stm32@...md-mailman.stormreply.com
Subject: Re: [PATCH v4 4/6] dt-bindings: display: stm32-ltdc: add optional
st,fb-bpp property
Hey,
On Mon, Jun 19, 2023 at 06:55:23PM +0200, Dario Binacchi wrote:
> Boards that use the STM32F{4,7} series have limited amounts of RAM. The
> added property allows to size, within certain limits, the memory footprint
> required by the framebuffer.
Hmm, this sounds quite a lot like "software policy", since the actual
display doesn't have these limitations. Rob, Krzysztof?
>
> Signed-off-by: Dario Binacchi <dario.binacchi@...rulasolutions.com>
> ---
>
> (no changes since v1)
Really?
https://lore.kernel.org/all/?q=dfn:st,stm32-ltdc.yaml%20
You sure this shouldn't be "new in v4"?
> .../devicetree/bindings/display/st,stm32-ltdc.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml b/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml
> index d6ea4d62a2cf..1c3a3653579f 100644
> --- a/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml
> +++ b/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml
> @@ -42,6 +42,12 @@ properties:
> - for internal dpi input of the MIPI DSI host controller.
> Note: These 2 endpoints cannot be activated simultaneously.
>
> + st,fb-bpp:
Is there not a more understandable property name than this?
Maybe I just had to think about it because fbdev stuff aint something
I've worked with...
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: |
> + bit depth of framebuffer (8, 16 or 32)
> + maxItems: 1
Why not make it an enum, since there are only 4 values?
Cheers,
Conor.
> +
> required:
> - compatible
> - reg
> --
> 2.32.0
>
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists