[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87pm5rp34t.ffs@tglx>
Date: Mon, 19 Jun 2023 23:13:06 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: "Li, Xin3" <xin3.li@...el.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"x86@...nel.org" <x86@...nel.org>,
"kvm@...r.kernel.org" <kvm@...r.kernel.org>
Cc: "mingo@...hat.com" <mingo@...hat.com>,
"bp@...en8.de" <bp@...en8.de>,
"dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
"hpa@...or.com" <hpa@...or.com>,
"peterz@...radead.org" <peterz@...radead.org>,
"andrew.cooper3@...rix.com" <andrew.cooper3@...rix.com>,
"Christopherson,, Sean" <seanjc@...gle.com>,
"pbonzini@...hat.com" <pbonzini@...hat.com>,
"Shankar, Ravi V" <ravi.v.shankar@...el.com>,
"jiangshanlai@...il.com" <jiangshanlai@...il.com>,
"Kang, Shan" <shan.kang@...el.com>
Subject: RE: [PATCH v8 05/33] x86/traps: add external_interrupt() to
dispatch external interrupts
On Mon, Jun 19 2023 at 19:16, Li, Xin3 wrote:
>> > Add external_interrupt() to dispatch external interrupts to their handlers.
>> >
>> > If an external interrupt is a system interrupt, dipatch it through
>> > system_interrupt_handlers table, otherwise to
>> > dispatch_common_interrupt().
>>
>> This naming convention sucks. external interrupts which can be system
>> interrupts. Come on.
>
> This name dispatch_common_interrupt() comes from arch/x86/kernel/irq.c:
That's not the point. Your changelog says:
If an external interrupt is a system interrupt...
It's either an external interrupt which goes through common_interrupt()
or it is a system interrupt which goes through it's very own handler,
no?
Thanks,
tglx
Powered by blists - more mailing lists