linux-kernel - Re: [PATCH v4] block: add capacity validation in bdev_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <da21ac06-666f-01f1-fa8d-f660a83a9182@kernel.org>
Date:   Mon, 19 Jun 2023 10:20:53 +0900
From:   Damien Le Moal <dlemoal@...nel.org>
To:     Min Li <min15.li@...sung.com>, axboe@...nel.dk,
        willy@...radead.org, hch@....de, gregkh@...uxfoundation.org,
        wsa@...nel.org, vkoul@...nel.org
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] block: add capacity validation in bdev_add_partition()

On 6/19/23 18:12, Min Li wrote:
> In the function bdev_add_partition(),there is no check that the start
> and end sectors exceed the size of the disk before calling add_partition.
> When we call the block's ioctl interface directly to add a partition,
> and the capacity of the disk is set to 0 by driver,the command will
> continue to execute.
> 
> Signed-off-by: Min Li <min15.li@...sung.com>
> Reviewed-by: Christoph Hellwig <hch@....de>

Reviewed-by: Damien Le Moal <dlemoal@...nel.org>


-- 
Damien Le Moal
Western Digital Research