linux-kernel - Re: [PATCH] lib/test_printf.c: space required after that ','

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 19 Jun 2023 08:45:22 +0200
From:   Pavel Machek <pavel@....cz>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Steven Rostedt <rostedt@...dmis.org>, hexingwei001@...suo.com,
        pmladek@...e.com, senozhatsky@...omium.org,
        linux-kernel@...r.kernel.org, linux@...musvillemoes.dk
Subject: Re: [PATCH] lib/test_printf.c: space required after that ','

On Wed 2023-06-14 18:16:36, Andy Shevchenko wrote:
> On Wed, Jun 14, 2023 at 11:06:40AM -0400, Steven Rostedt wrote:
> > On Wed, 14 Jun 2023 15:32:30 +0300
> > Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
> > > On Wed, Jun 14, 2023 at 04:30:55PM +0800, hexingwei001@...suo.com wrote:
> > > > Add missing spaces to clear checkpatch errors:
> > > > 
> > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV).
> > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV).
> > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV).
> > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV).
> > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV).
> > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV).  
> > > 
> > > Doesn't make any difference to the code, so let do this (unneeded) churn
> > > to calm checkpatch down.
> > > 
> > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > 
> > checkpatch is for patches (new code) and should not be run on existing code.
> 
> Why does it have -f option? What do you propose to prevent people from using it?

Brain needs to be used while using checkpatch.

Plus, autosel is "great" trying to backport anything that mentions
"error", so better don't do this.

Best regards,
							Pavel
-- 
People of Russia, stop Putin before his war on Ukraine escalates.

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)