linux-kernel - [PATCH v1] ASoC: loongson: change the type of variable irq to int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230619074649.3608726-1-mengyingkun@loongson.cn>
Date:   Mon, 19 Jun 2023 15:46:49 +0800
From:   YingKun Meng <mengyingkun@...ngson.cn>
To:     broonie@...nel.org, lgirdwood@...il.com
Cc:     harshit.m.mogalapalli@...cle.com, krzysztof.kozlowski@...aro.org,
        linux-kernel@...r.kernel.org, alsa-devel@...a-project.org,
        loongarch@...ts.linux.dev, loongson-kernel@...ts.loongnix.cn,
        YingKun Meng <mengyingkun@...ngson.cn>
Subject: [PATCH v1] ASoC: loongson: change the type of variable irq to int

We use variable 'irq' to store the return value of fwnode_get_irq_byname().
A negative value indicates that the operation failed. If the type of 'irq'
is unsigned int, we never know if the operation failed.

Reported-by: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
Closes: https://lore.kernel.org/loongarch/325dd825-6fa5-0ebc-4b7e-7acf2d2840e4@loongson.cn/
Signed-off-by: YingKun Meng <mengyingkun@...ngson.cn>
---
 sound/soc/loongson/loongson_i2s.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/loongson/loongson_i2s.h b/sound/soc/loongson/loongson_i2s.h
index 52788f6a94ad..89492eebf834 100644
--- a/sound/soc/loongson/loongson_i2s.h
+++ b/sound/soc/loongson/loongson_i2s.h
@@ -45,7 +45,7 @@
 struct loongson_dma_data {
 	dma_addr_t dev_addr;		/* device physical address for DMA */
 	void __iomem *order_addr;	/* DMA order register */
-	u32 irq;			/* DMA irq */
+	int irq;			/* DMA irq */
 };
 
 struct loongson_i2s {
-- 
2.33.0