linux-kernel - arch/um/drivers/virt-pci.c:537:21: warning: no previous prototype for function 'pcibios_get_phb_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202306190737.Z3uYTGpX-lkp@intel.com>
Date:   Mon, 19 Jun 2023 15:54:39 +0800
From:   kernel test robot <yujie.liu@...el.com>
To:     Vincent Whitchurch <vincent.whitchurch@...s.com>
CC:     <llvm@...ts.linux.dev>, <oe-kbuild-all@...ts.linux.dev>,
        <linux-kernel@...r.kernel.org>, Richard Weinberger <richard@....at>
Subject: arch/um/drivers/virt-pci.c:537:21: warning: no previous prototype
 for function 'pcibios_get_phb_of_node'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   45a3e24f65e90a047bef86f927ebdc4c710edaa1
commit: 314a1408b79a844dafdcde867d90de5d509409b7 um: virt-pci: implement pcibios_get_phb_of_node()
date:   4 months ago
config: um-randconfig-r002-20230619 (https://download.01.org/0day-ci/archive/20230619/202306190737.Z3uYTGpX-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce: (https://download.01.org/0day-ci/archive/20230619/202306190737.Z3uYTGpX-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <yujie.liu@...el.com>
| Closes: https://lore.kernel.org/r/202306190737.Z3uYTGpX-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> arch/um/drivers/virt-pci.c:537:21: warning: no previous prototype for function 'pcibios_get_phb_of_node' [-Wmissing-prototypes]
   struct device_node *pcibios_get_phb_of_node(struct pci_bus *bus)
                       ^
   arch/um/drivers/virt-pci.c:537:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   struct device_node *pcibios_get_phb_of_node(struct pci_bus *bus)
   ^
   static 


vim +/pcibios_get_phb_of_node +537 arch/um/drivers/virt-pci.c

68f5d3f3b65432 Johannes Berg      2021-03-05  535  
314a1408b79a84 Vincent Whitchurch 2023-01-20  536  /* Copied from arch/x86/kernel/devicetree.c */
314a1408b79a84 Vincent Whitchurch 2023-01-20 @537  struct device_node *pcibios_get_phb_of_node(struct pci_bus *bus)
314a1408b79a84 Vincent Whitchurch 2023-01-20  538  {
314a1408b79a84 Vincent Whitchurch 2023-01-20  539  	struct device_node *np;
314a1408b79a84 Vincent Whitchurch 2023-01-20  540  
314a1408b79a84 Vincent Whitchurch 2023-01-20  541  	for_each_node_by_type(np, "pci") {
314a1408b79a84 Vincent Whitchurch 2023-01-20  542  		const void *prop;
314a1408b79a84 Vincent Whitchurch 2023-01-20  543  		unsigned int bus_min;
314a1408b79a84 Vincent Whitchurch 2023-01-20  544  
314a1408b79a84 Vincent Whitchurch 2023-01-20  545  		prop = of_get_property(np, "bus-range", NULL);
314a1408b79a84 Vincent Whitchurch 2023-01-20  546  		if (!prop)
314a1408b79a84 Vincent Whitchurch 2023-01-20  547  			continue;
314a1408b79a84 Vincent Whitchurch 2023-01-20  548  		bus_min = be32_to_cpup(prop);
314a1408b79a84 Vincent Whitchurch 2023-01-20  549  		if (bus->number == bus_min)
314a1408b79a84 Vincent Whitchurch 2023-01-20  550  			return np;
314a1408b79a84 Vincent Whitchurch 2023-01-20  551  	}
314a1408b79a84 Vincent Whitchurch 2023-01-20  552  	return NULL;
314a1408b79a84 Vincent Whitchurch 2023-01-20  553  }
314a1408b79a84 Vincent Whitchurch 2023-01-20  554  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki