linux-kernel - Re: [PATCH V3 2/7] wifi: mac80211: Add support for ACPI WBRF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a19bd3074d2763b02a722f31713bbf3bae97e8f.camel@sipsolutions.net>
Date:   Mon, 19 Jun 2023 10:24:25 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     Mario Limonciello <mario.limonciello@....com>,
        Evan Quan <evan.quan@....com>
Cc:     linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
        amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-wireless@...r.kernel.org, rafael@...nel.org, lenb@...nel.org,
        Alexander.Deucher@....com, Christian.Koenig@....com,
        Xinhui.Pan@....com, airlied@...il.com, daniel@...ll.ch,
        kvalo@...nel.org, nbd@....name, lorenzo@...nel.org,
        ryder.lee@...iatek.com, shayne.chen@...iatek.com,
        sean.wang@...iatek.com, matthias.bgg@...il.com,
        angelogioacchino.delregno@...labora.com, Lijo.Lazar@....com
Subject: Re: [PATCH V3 2/7] wifi: mac80211: Add support for ACPI WBRF

On Sun, 2023-06-18 at 21:17 -0500, Mario Limonciello wrote:
> 
> > --- a/include/net/cfg80211.h
> > +++ b/include/net/cfg80211.h
> > @@ -920,6 +920,14 @@ const struct cfg80211_chan_def *
> >   cfg80211_chandef_compatible(const struct cfg80211_chan_def *chandef1,
> >   			    const struct cfg80211_chan_def *chandef2);
> >   
> > +/**
> > + * nl80211_chan_width_to_mhz - get the channel width in Mhz
> > + * @chan_width: the channel width from &enum nl80211_chan_width
> > + * Return: channel width in Mhz if the chan_width from &enum nl80211_chan_width
> > + * is valid. -1 otherwise.
> > + */
> > +int nl80211_chan_width_to_mhz(enum nl80211_chan_width chan_width);
> > +
> 
> It's up to mac80211 maintainers, but I would think that the changes to 
> change nl80211_chan_width_to_mhz from static to exported should be 
> separate from the patch to introduced WBRF support in the series.

Yeah, that'd be nice :)


> > +#define KHZ_TO_HZ(freq)		((freq) * 1000ULL)

Together with MHZ_TO_KHZ() for example :)

johannes