linux-kernel - Re: [PATCH v14 11/18] media: i2c: ds90ub9xx: Select GPIOLIB rather than OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 19 Jun 2023 11:40:28 +0300
From:   Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-media@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
        Luca Ceresoli <luca.ceresoli@...tlin.com>,
        Matti Vaittinen <Matti.Vaittinen@...rohmeurope.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Wolfram Sang <wsa@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Peter Rosin <peda@...ntia.se>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Michael Tretter <m.tretter@...gutronix.de>,
        Hans Verkuil <hverkuil@...all.nl>,
        Mike Pagano <mpagano@...too.org>,
        Krzysztof Hałasa <khalasa@...p.pl>,
        Marek Vasut <marex@...x.de>,
        Satish Nagireddy <satish.nagireddy@...cruise.com>
Subject: Re: [PATCH v14 11/18] media: i2c: ds90ub9xx: Select GPIOLIB rather
 than OF_GPIO

On 16/06/2023 17:17, Andy Shevchenko wrote:
> On Fri, Jun 16, 2023 at 04:59:15PM +0300, Tomi Valkeinen wrote:
>> Select GPIOLIB rather than OF_GPIO, as the drivers use gpiolib
>> functionality, but no of_gpio (directly).
> 
> This is useful change, but has to be folded in the original code.
> We do not want even a trace of newly added OF_GPIO.

Yes, I think the first three new patches should be squashed:

   media: i2c: ds90ub960: Fix use of UB960_SR_FWD_CTL1
   media: i2c: ds90ub9xx: Add COMMON_CLK kconfig dependency
   media: i2c: ds90ub9xx: Select GPIOLIB rather than OF_GPIO

The rest... Thinking about it now, I should have perhaps left them out, 
as they're not fixing issues, and perhaps they just confuse the merging 
process.

  Tomi

> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> 
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
>> ---
>>   drivers/media/i2c/Kconfig | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
>> index 8a5f09a3de6c..29fc00e30d8b 100644
>> --- a/drivers/media/i2c/Kconfig
>> +++ b/drivers/media/i2c/Kconfig
>> @@ -1622,7 +1622,7 @@ config VIDEO_DS90UB913
>>   	depends on OF && I2C && VIDEO_DEV && COMMON_CLK
>>   	select I2C_ATR
>>   	select MEDIA_CONTROLLER
>> -	select OF_GPIO
>> +	select GPIOLIB
>>   	select REGMAP_I2C
>>   	select V4L2_FWNODE
>>   	select VIDEO_V4L2_SUBDEV_API
>> @@ -1635,7 +1635,7 @@ config VIDEO_DS90UB953
>>   	depends on OF && I2C && VIDEO_DEV && COMMON_CLK
>>   	select I2C_ATR
>>   	select MEDIA_CONTROLLER
>> -	select OF_GPIO
>> +	select GPIOLIB
>>   	select REGMAP_I2C
>>   	select V4L2_FWNODE
>>   	select VIDEO_V4L2_SUBDEV_API
>> @@ -1648,7 +1648,7 @@ config VIDEO_DS90UB960
>>   	depends on OF && I2C && VIDEO_DEV && COMMON_CLK
>>   	select I2C_ATR
>>   	select MEDIA_CONTROLLER
>> -	select OF_GPIO
>> +	select GPIOLIB
>>   	select REGMAP_I2C
>>   	select V4L2_FWNODE
>>   	select VIDEO_V4L2_SUBDEV_API
>> -- 
>> 2.34.1
>>
>