[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACRpkdaNqELB8OtCuEbqny80OvJnxo1Ggw4kEQQ59+9BonDpeA@mail.gmail.com>
Date: Mon, 19 Jun 2023 10:57:48 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Shubhrajyoti Datta <shubhrajyoti.datta@....com>,
Bartosz Golaszewski <brgl@...ev.pl>,
Michal Simek <michal.simek@....com>,
Manikanta Guntupalli <manikanta.guntupalli@....com>,
Arnd Bergmann <arnd@...db.de>,
Srinivas Neeli <srinivas.neeli@....com>,
Andy Shevchenko <andy@...nel.org>, linux-gpio@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpio: synq: remove unused zynq_gpio_irq_reqres/zynq_gpio_irq_relres
On Fri, Jun 16, 2023 at 4:50 PM Arnd Bergmann <arnd@...nel.org> wrote:
> From: Arnd Bergmann <arnd@...db.de>
>
> The driver now uses the generic request/release callbacks, so the custom
> ones are no longer called. When building with -Woverride-init, gcc produces
> a warning about the duplicate entries:
>
> In file included from drivers/gpio/gpio-zynq.c:10:
> include/linux/gpio/driver.h:621:43: error: initialized field overwritten [-Werror=override-init]
> 621 | .irq_request_resources = gpiochip_irq_reqres, \
> | ^~~~~~~~~~~~~~~~~~~
> drivers/gpio/gpio-zynq.c:611:9: note: in expansion of macro 'GPIOCHIP_IRQ_RESOURCE_HELPERS'
> 611 | GPIOCHIP_IRQ_RESOURCE_HELPERS,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/linux/gpio/driver.h:621:43: note: (near initialization for 'zynq_gpio_level_irqchip.irq_request_resources')
> 621 | .irq_request_resources = gpiochip_irq_reqres, \
> | ^~~~~~~~~~~~~~~~~~~
> drivers/gpio/gpio-zynq.c:625:9: note: in expansion of macro 'GPIOCHIP_IRQ_RESOURCE_HELPERS'
> 625 | GPIOCHIP_IRQ_RESOURCE_HELPERS,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/linux/gpio/driver.h:622:43: error: initialized field overwritten [-Werror=override-init]
> 622 | .irq_release_resources = gpiochip_irq_relres
> | ^~~~~~~~~~~~~~~~~~~
>
> Removing the old ones has no effect on the driver but avoids the warnings.
>
> Fixes: f569143935378 ("gpio: zynq: fix zynqmp_gpio not an immutable chip warning")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
Right.
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
Yours,
Linus Walleij
Powered by blists - more mailing lists