linux-kernel - Re: [PATCH v1] drivers: meson: secure-pwrc: always enable DMA domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0d50047b-b30a-9c20-1754-2ee4fc4f7e18@linaro.org>
Date:   Mon, 19 Jun 2023 11:00:17 +0200
From:   neil.armstrong@...aro.org
To:     Alexey Romanov <avromanov@...rdevices.ru>, narmstrong@...libre.com,
        khilman@...libre.com, jbrunet@...libre.com,
        martin.blumenstingl@...glemail.com
Cc:     linux-arm-kernel@...ts.infradead.org, kernel@...rdevices.ru,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] drivers: meson: secure-pwrc: always enable DMA domain

On 10/06/2023 11:04, Alexey Romanov wrote:
> Starting from commit e45f243409db ("firmware: meson_sm:
> populate platform devices from sm device tree data") pwrc
> is probed successfully and disables unused pwr domains.
> By A1 SoC family design, any TEE requires DMA pwr domain
> always enabled.
> 
> Signed-off-by: Alexey Romanov <avromanov@...rdevices.ru>
> ---
> I'm not entirely sure if this domain should always be enabled on or it
> should be separately enabled in dts file. Comments are welcome.
> ---
>   drivers/soc/amlogic/meson-secure-pwrc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/amlogic/meson-secure-pwrc.c b/drivers/soc/amlogic/meson-secure-pwrc.c
> index e93518763526..25b4b71df9b8 100644
> --- a/drivers/soc/amlogic/meson-secure-pwrc.c
> +++ b/drivers/soc/amlogic/meson-secure-pwrc.c
> @@ -105,7 +105,7 @@ static struct meson_secure_pwrc_domain_desc a1_pwrc_domains[] = {
>   	SEC_PD(ACODEC,	0),
>   	SEC_PD(AUDIO,	0),
>   	SEC_PD(OTP,	0),
> -	SEC_PD(DMA,	0),
> +	SEC_PD(DMA,	GENPD_FLAG_ALWAYS_ON | GENPD_FLAG_IRQ_SAFE),
>   	SEC_PD(SD_EMMC,	0),
>   	SEC_PD(RAMA,	0),
>   	/* SRAMB is used as ATF runtime memory, and should be always on */

It's fine to keep it enabled.

Acked-by: Neil Armstrong <neil.armstrong@...aro.org>

Neil